Skip to content

fix: traincascade, use C++ persistence API#23594

Merged
asmorkalov merged 2 commits intoopencv:4.xfrom
fdivitto:fdivitto-traincascade-patch
May 23, 2023
Merged

fix: traincascade, use C++ persistence API#23594
asmorkalov merged 2 commits intoopencv:4.xfrom
fdivitto:fdivitto-traincascade-patch

Conversation

@fdivitto
Copy link
Copy Markdown
Contributor

@fdivitto fdivitto commented May 9, 2023

This pull allows to compile traincascade application with OpenCV 4.6. Changes uses new persistence C++ API in place of legacy one.

@opencv-alalek opencv-alalek added the category: apps OpenCV builtin tools label May 9, 2023
@asmorkalov asmorkalov self-requested a review May 10, 2023 11:09
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov added the cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) label May 22, 2023
@asmorkalov
Copy link
Copy Markdown
Contributor

@fdivitto Thanks a lot for the patch! I disabled traincascade app back before the PR merge.

@asmorkalov asmorkalov merged commit 044a322 into opencv:4.x May 23, 2023
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
thewoz pushed a commit to thewoz/opencv that referenced this pull request Jan 4, 2024
…atch

fix: traincascade, use C++ persistence API opencv#23594

This pull allows to compile traincascade application with OpenCV 4.6. Changes uses new persistence C++ API in place of legacy one.
thewoz pushed a commit to thewoz/opencv that referenced this pull request May 29, 2024
…atch

fix: traincascade, use C++ persistence API opencv#23594

This pull allows to compile traincascade application with OpenCV 4.6. Changes uses new persistence C++ API in place of legacy one.
@TonyCongqianWang
Copy link
Copy Markdown

Is there a reason why traincascade is still disabled in the Apps CMakeList? Can it safely be enabled or are there still some caveats?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: apps OpenCV builtin tools cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants