Skip to content

Fix build regression in Quirc#23484

Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom
AleksandrPanov:fix_warnings_quirc
Apr 12, 2023
Merged

Fix build regression in Quirc#23484
opencv-pushbot merged 1 commit intoopencv:4.xfrom
AleksandrPanov:fix_warnings_quirc

Conversation

@AleksandrPanov
Copy link
Copy Markdown
Contributor

@AleksandrPanov AleksandrPanov commented Apr 12, 2023 •
edited by asmorkalov
Loading

Introduced in #23275
Buildbot report: https://pullrequest.opencv.org/buildbot/builders/4_x_ARMv7-lin/builds/100067/steps/compile%20release/logs/stdio

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added this to the 4.8.0 milestone Apr 12, 2023
@asmorkalov asmorkalov changed the title fix_warnings_quirc Fix build regression in Quirc Apr 12, 2023
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Apr 12, 2023

@opencv-alalek Could you take a look on armv7 build issue. it's not relevant to the PR changes:

In file included from /build/precommit_armv7/4.x/opencv/modules/python/src2/cv2.cpp:5:0:
/build/precommit_armv7/4.x/opencv/modules/python/src2/cv2.hpp:20:20: fatal error: Python.h: No such file or directory
 #include <Python.h>
                    ^
compilation terminated.
make[2]: *** [modules/python2/CMakeFiles/opencv_python2.dir/__/src2/cv2.cpp.o] Error 1
make[2]: Leaving directory `/build/precommit_armv7/build'
make[1]: *** [modules/python2/CMakeFiles/opencv_python2.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

@asmorkalov asmorkalov self-requested a review April 12, 2023 13:24
asmorkalov
asmorkalov approved these changes Apr 12, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested manually with jetson-tk1 and ubuntu 16.04 (gcc 5).

opencv-alalek
opencv-alalek approved these changes Apr 12, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@opencv-alalek opencv-alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@opencv-alalek opencv-alalek self-assigned this Apr 12, 2023
@opencv-pushbot opencv-pushbot merged commit 24387c2 into opencv:4.x Apr 12, 2023
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

@opencv-alalek opencv-alalek opencv-alalek approved these changes

Assignees

@opencv-alalek opencv-alalek

Labels

category: build/install category: 3rdparty

Projects

None yet

Milestone

4.8.0

Development

Successfully merging this pull request may close these issues.

4 participants

@AleksandrPanov @asmorkalov @opencv-alalek @opencv-pushbot