Added QR_Code data flip support, flip and retry after first ECC failure#23275
Conversation
|
@alalek The test data for this PR is in : opencv_extra/pull/1046. |
de7ea8d to
de944b3
Compare
|
@alalek @AleksandrPanov Is there something left to do in this PR from my side ? |
|
@genciberisha I found this issue in the quirc library: Your solution to the problem is correct, thank you. Test images must be converted to jpg to take up less space. |
|
The PR contains 2 tests that are dependent. It's not stable solution for testing. I propose to remove generator part and hardcode information as static array. There are only 2 images, not need to dump regression data to file. |
7b02524 to
36bc181
Compare
|
@AleksandrPanov Converting these images to JPG decreases the size a little but also with a lot off quality loss. @asmorkalov Agreed, I removed the generation test and replaced it with a simple validation test. |
AleksandrPanov
left a comment
There was a problem hiding this comment.
@genciberisha, thank you
I consider this solution to be optimal, because it's like quirc's solution.
Added regression test for the flipped images
36bc181 to
a1b4aa5
Compare
|
@alalek Seems there isn't anything left here to do, thank you. |
|
There is build error: |
|
@AleksandrPanov Could you fix it? |
Merge with extra: opencv/opencv_extra#1046
Fixes #23249, fixes #23155, fixes #20724
Added quirc_flip() method to horizontally flip the data.
When the decoder fails to ECC the data we flip the image, and try one more time.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.