Fix ONNX parser for single-layer LSTM hidden and cell states#23475
Merged
asmorkalov merged 6 commits intoopencv:4.xfrom Apr 24, 2023
Merged
Fix ONNX parser for single-layer LSTM hidden and cell states#23475asmorkalov merged 6 commits intoopencv:4.xfrom
asmorkalov merged 6 commits intoopencv:4.xfrom
Conversation
rogday
suggested changes
Apr 9, 2023
dkurt
reviewed
Apr 10, 2023
Member
|
Not related to this PR but I see in some cases our ONNX parser inserts several layers to properly execute LSTM layer. Could it be fixed so that we do not need those extra layers? |
initialization
rogday
suggested changes
Apr 16, 2023
rogday
approved these changes
Apr 24, 2023
Member
rogday
left a comment
There was a problem hiding this comment.
Looks good, with minor comments.
Member
|
We had a branch with test for this pr, didn't we? |
Contributor
|
There is even PR with testdata: opencv/opencv_extra#1052 |
Member
|
@Abdurrahheem, can you please add tests for new functionality? |
4 tasks
Member
6 tasks
Merged
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
Jan 4, 2024
…tion Fix ONNX parser for single-layer LSTM hidden and cell states opencv#23475 ### Fix ONNX parser for single-layer LSTM hidden and cell states ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake This PR addresses opencv#21118 [issue](opencv#21118). The problem is that the ONNX parser is unable to read the hidden state and cell state for single-layer LSTMs. This PR fixes the issue by updating the parser to correctly read hidden and cell states.
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
May 29, 2024
…tion Fix ONNX parser for single-layer LSTM hidden and cell states opencv#23475 ### Fix ONNX parser for single-layer LSTM hidden and cell states ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake This PR addresses opencv#21118 [issue](opencv#21118). The problem is that the ONNX parser is unable to read the hidden state and cell state for single-layer LSTMs. This PR fixes the issue by updating the parser to correctly read hidden and cell states.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix ONNX parser for single-layer LSTM hidden and cell states
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
This PR addresses #21118 issue. The problem is that the ONNX parser is unable to read the hidden state and cell state for single-layer LSTMs. This PR fixes the issue by updating the parser to correctly read hidden and cell states.