bmp decoder fix scale factor and IMREAD_COLOR incorrect result#23446
Merged
asmorkalov merged 3 commits intoopencv:4.xfrom Apr 6, 2023
Merged
bmp decoder fix scale factor and IMREAD_COLOR incorrect result#23446asmorkalov merged 3 commits intoopencv:4.xfrom
asmorkalov merged 3 commits intoopencv:4.xfrom
Conversation
Signed-off-by: Shreesh Adiga <16567adigashreesh@gmail.com>
Contributor
|
@tantei3 Thanks a lot for the prompt patch! I just tried branch 3.4 and the issue is there too. Please rebase the PR on top of 3.4 (or cherry-pick), push it to the same branch and change the PR target to 3.4. Also it's good to have some test for the issue. Could you create PR with the same branch name to opencv/opencv_extra repo with smallest possible image like 16x16 or 32x32 and implement test for it. |
Contributor
Author
|
@asmorkalov test case has been added. Regarding rebase, |
Ebuka636
approved these changes
Apr 2, 2023
Contributor
|
Got it, please ignore my request about 3.4. I'll take a look on it later. |
asmorkalov
approved these changes
Apr 6, 2023
Contributor
|
Thanks a lot for the contribution! The patch was tested manually with Ubuntu 18.04. |
Merged
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
Jan 4, 2024
**Merge with extra**: opencv/opencv_extra#1050 For 32 bits per pixel with 3 or 4 channel destination images, apply scale factor and mask to parse BMP files correctly closes opencv#23445 ### Pull Request Readiness Checklist - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
May 29, 2024
**Merge with extra**: opencv/opencv_extra#1050 For 32 bits per pixel with 3 or 4 channel destination images, apply scale factor and mask to parse BMP files correctly closes opencv#23445 ### Pull Request Readiness Checklist - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge with extra: opencv/opencv_extra#1050
For 32 bits per pixel with 3 or 4 channel destination images, apply scale factor and mask to parse BMP files correctly
closes #23445
Pull Request Readiness Checklist
Patch to opencv_extra has the same branch name.