Fix python bindings for setCharucoParameters#23436
Conversation
setcharucoparameters fails in python
| should be changed too |
|
@dkurt thank you for the reference, and thank you @siilats for the workaround, however I think there is still a bug. When I do a charuco find markers without using the intrinsics and distortions (i.e. a factory CharucoParamaters) the calibration/poses derived are reasonable but not great. However when i feed in the ground truth intrinsics/distortions using CharucoParameters, the result is terrible/very wrong. I have only noticed this because we have upgraded our repo from opencv 4.1 to 4.7; in the old code everything worked completely fine. |
|
@mostafarohani, I've added a test in Python, can you please take a look and if your example is different, please provide a reproducer. Update: I were able to reproduce your issue, sorry. This is only when either |
AleksandrPanov
left a comment
There was a problem hiding this comment.
It is possible to add more clear names instead of test_charuco_no_segfault_1, test_charuco_no_segfault_2. The tests are small and there are comments, so it's ok for me.
|
@AleksandrPanov, sure, done! |
Fix python bindings for setCharucoParameters opencv#23436 setCharucoParameters fails in python Fixes: opencv#23440 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
Fix python bindings for setCharucoParameters opencv#23436 setCharucoParameters fails in python Fixes: opencv#23440 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
setcharucoparameters fails in python
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
This hack works meanwhile:
