Skip to content

Fix reference counting errors in registerNewType#23350

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
spikethehobbitmage:4.x
Apr 3, 2023
Merged

Fix reference counting errors in registerNewType#23350
asmorkalov merged 1 commit intoopencv:4.xfrom
spikethehobbitmage:4.x

Conversation

@spikethehobbitmage
Copy link
Copy Markdown
Contributor

@spikethehobbitmage spikethehobbitmage commented Mar 14, 2023 •
edited
Loading

Fixes #23059

Fix reference counting error in registerNewType so it no longer double-steals sometimes.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • N/A There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Edit: Fixes bug, not just related.

@asmorkalov asmorkalov requested a review from VadimLevin March 14, 2023 07:42
@spikethehobbitmage spikethehobbitmage marked this pull request as ready for review March 14, 2023 17:57
VadimLevin
VadimLevin reviewed Mar 21, 2023
View reviewed changes
mshumko added a commit to mshumko/asilib that referenced this pull request Mar 29, 2023
@mshumko
Removed TREx ASI due to an OpenCV
eb017fc 
bug that crashes the trex_imager_readfile. There is an unaproved PR that
should fix it: opencv/opencv#23350.

I created a "trex_backup" branch to save the trex_nir code.
@asmorkalov asmorkalov added the bug label Apr 3, 2023
@asmorkalov asmorkalov added this to the 4.8.0 milestone Apr 3, 2023
@asmorkalov asmorkalov merged commit 66a5ecb into opencv:4.x Apr 3, 2023
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VadimLevin VadimLevin VadimLevin approved these changes

Assignees

@VadimLevin VadimLevin

Labels

bug category: python bindings

Projects

None yet

Milestone

4.8.0

Development

Successfully merging this pull request may close these issues.

Potential reference counting error in Python module

3 participants

@spikethehobbitmage @VadimLevin @asmorkalov