Skip to content

Propagate inputs info for ONNX and TFLite models#23325

Merged
asmorkalov merged 2 commits intoopencv:4.xfrom
dkurt:dnn_input_info
Mar 21, 2023
Merged

Propagate inputs info for ONNX and TFLite models#23325
asmorkalov merged 2 commits intoopencv:4.xfrom
dkurt:dnn_input_info

Conversation

@dkurt
Copy link
Copy Markdown
Member

@dkurt dkurt commented Mar 3, 2023 •
edited
Loading

Pull Request Readiness Checklist

Needed for generic applications such as benchmarking pipelines. So OpenCV can tell about the default input shapes specified in the models.

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov requested a review from rogday March 14, 2023 05:40
asmorkalov
asmorkalov reviewed Mar 14, 2023
View reviewed changes
@dkurt
Copy link
Copy Markdown
Member Author

dkurt commented Mar 14, 2023

Seems there is an unstable test: https://pullrequest.opencv.org/buildbot/builders/precommit_windows64/builds/101037

[ RUN      ] Conv3D.conv3d/14, where GetParam() = (GFLOPS=0.000, K=[1 x 1 x 1], IN={1, 8, 1, 10, 10}, OCN=8, G=8, P=(1, 1) x (1, 1) x (1, 1), BIAS, OCV/CPU)
C:\build\precommit_windows64\4.x\opencv\modules\ts\src\ts_perf.cpp(1975): error: Failed
Expected: PerfTestBody() doesn't throw an exception.
  Actual: it throws...
params    = (GFLOPS=0.000, K=[1 x 1 x 1], IN={1, 8, 1, 10, 10}, OCN=8, G=8, P=(1, 1) x (1, 1) x (1, 1), BIAS, OCV/CPU)
termination reason:  unhandled exception
bytesIn   =          0
bytesOut  =          0
samples   =          0 of 1
outliers  =          0
frequency =          0
[  FAILED  ] Conv3D.conv3d/14, where GetParam() = (GFLOPS=0.000, K=[1 x 1 x 1], IN={1, 8, 1, 10, 10}, OCN=8, G=8, P=(1, 1) x (1, 1) x (1, 1), BIAS, OCV/CPU) (3 ms)

@asmorkalov asmorkalov requested a review from vpisarev March 14, 2023 10:10
@asmorkalov asmorkalov self-assigned this Mar 21, 2023
@asmorkalov asmorkalov added this to the 4.8.0 milestone Mar 21, 2023
@asmorkalov asmorkalov merged commit 5df6b4a into opencv:4.x Mar 21, 2023
@dkurt dkurt deleted the dnn_input_info branch March 21, 2023 13:59
hanliutong pushed a commit to hanliutong/opencv that referenced this pull request Mar 27, 2023
@dkurt @hanliutong
Merge pull request opencv#23325 from dkurt:dnn_input_info
64070a3 
Propagate inputs info for ONNX and TFLite models

### Pull Request Readiness Checklist

Needed for generic applications such as benchmarking pipelines. So OpenCV can tell about the default input shapes specified in the models.

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [x] The feature is well documented and sample code can be built with the project CMake
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

@rogday rogday Awaiting requested review from rogday

@vpisarev vpisarev Awaiting requested review from vpisarev

Assignees

@asmorkalov asmorkalov

Labels

category: dnn

Projects

None yet

Milestone

4.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@dkurt @asmorkalov