Skip to content

Fixed strict type in slerp and spline; Fixed nlerp usage condition#23301

Merged
asmorkalov merged 2 commits intoopencv:4.xfrom
shtern:fix_quaternion
Mar 10, 2023
Merged

Fixed strict type in slerp and spline; Fixed nlerp usage condition#23301
asmorkalov merged 2 commits intoopencv:4.xfrom
shtern:fix_quaternion

Conversation

@shtern
Copy link
Copy Markdown
Contributor

@shtern shtern commented Feb 24, 2023 •
edited by alalek
Loading

Fixes #23293

The PR is fixing the issue described in Issue #23293

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Feb 27, 2023

@shtern Could you add simple slerp test for float?

@asmorkalov asmorkalov added the pr: needs test New functionality requires minimal tests set label Feb 27, 2023
@alalek
Copy link
Copy Markdown
Member

alalek commented Feb 27, 2023

@asmorkalov What kind of test do you assume? Regression test is likely impossible (in a reliable way).

@shtern
Copy link
Copy Markdown
Contributor Author

shtern commented Feb 27, 2023

@asmorkalov @alalek do you have any idea why would the default build fail?
https://pullrequest.opencv.org/buildbot/builders/precommit_linux64/builds/102755/steps/Compare%20ABI%20dumps/logs/report-html
Doesn't seem to have any sense that 69 symbols are removed. Is there an issue in ABI comparison script maybe?

@asmorkalov asmorkalov removed the pr: needs test New functionality requires minimal tests set label Feb 27, 2023
@alalek
Copy link
Copy Markdown
Member

alalek commented Feb 27, 2023

@shtern Please ignore. There is an issue with ABI/API checker tool.
Need to update its configuration on CI (I will recheck and will update later on this week).

@shtern
Copy link
Copy Markdown
Contributor Author

shtern commented Feb 27, 2023

@alalek
Thank you for your answer.
I guess the PR is good to go then?

@shtern
Copy link
Copy Markdown
Contributor Author

shtern commented Mar 6, 2023

@alalek @asmorkalov
Thanks for fixing the CI, all the checks have passed. It looks like the PR is ready to be merged?

@asmorkalov asmorkalov self-requested a review March 6, 2023 16:56
@asmorkalov asmorkalov changed the title Fixed strict type in slerp and spline; Fixed nlerp usage condition in… Fixed strict type in slerp and spline; Fixed nlerp usage condition Mar 10, 2023
@asmorkalov asmorkalov merged commit c6e5f60 into opencv:4.x Mar 10, 2023
@asmorkalov asmorkalov self-assigned this Mar 10, 2023
hanliutong pushed a commit to hanliutong/opencv that referenced this pull request Mar 27, 2023
@shtern @hanliutong
Merge pull request opencv#23301 from shtern:fix_quaternion
ce2f9ae 
Fixed strict type in slerp and spline; Fixed nlerp usage condition

Fixes opencv#23293

The PR is fixing the issue described in [Issue opencv#23293 ](opencv#23293)

- [X] I agree to contribute to the project under Apache 2 License.
- [X] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [X] The PR is proposed to the proper branch
- [X] There is a reference to the original bug report and related work
- [X] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [X] The feature is well documented and sample code can be built with the project CMake
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

bug category: core

Projects

None yet

Milestone

4.8.0

Development

Successfully merging this pull request may close these issues.

Quaternion SLERP: templated function supports only double

3 participants

@shtern @asmorkalov @alalek