DNN: fix possible segmentation fault error in winograd on x86#23112
Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom Jan 9, 2023
Merged
DNN: fix possible segmentation fault error in winograd on x86#23112opencv-pushbot merged 1 commit intoopencv:4.xfrom
opencv-pushbot merged 1 commit intoopencv:4.xfrom
Conversation
This was referenced Jan 8, 2023
Closed
This was
linked to
issues
Jan 9, 2023
d4442a6 to
82616ee
Compare
alalek
approved these changes
Jan 9, 2023
Merged
4 tasks
john-forrest
pushed a commit
to idscan/opencv
that referenced
this pull request
Feb 13, 2023
(cherry picked from commit 82616ee) (Cherry-pick of opencv#23112)
gnomesysadmins
pushed a commit
to GNOME/shotwell
that referenced
this pull request
Jun 12, 2023
keighrim
added a commit
to clamsproject/app-east-textdetection
that referenced
this pull request
Jun 18, 2023
keighrim
added a commit
to clamsproject/clams-python
that referenced
this pull request
Jun 30, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The segmentation fault error only happens in AVX only platform, while the
CV_TRY_AVX2is true andcheckHardwareSupport(CPU_AVX2)is false. And this inconsistency will cause Winograd branch code to enter the wrong memory block. And in AVX only platform, the Winograd can not be speeded up by AVX or AVX2 which will be slower than the generic Convolution branch. So, in short term, I think disabling Winograd is a better solution.And for a long-term solution, we should support Winograd at https://github.com/opencv/opencv/blob/4.x/modules/dnn/src/layers/layers_common.simd.hpp. After that, OpenCV can automatically generate AVX or AVX2 code for Winograd based on CPU instruction set. I will try to implement this.
detailed discussion: cocoa-xu/evision#153 (comment).
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.