G-API: replace GAPI_Assert() with 'false' and '0' to GAPI_Error()#22935
Merged
alalek merged 4 commits intoopencv:4.xfrom Dec 19, 2022
Merged
G-API: replace GAPI_Assert() with 'false' and '0' to GAPI_Error()#22935alalek merged 4 commits intoopencv:4.xfrom
alalek merged 4 commits intoopencv:4.xfrom
Conversation
Member
Author
|
/cc @dmatveev |
- observed in constructors stubs with throwing exception
Member
Author
|
@dmatveev Need someone who can check G-API "standalone" mode. |
Contributor
|
@dmatveev friendly reminder. |
Member
Author
|
@dmatveev Standalone G-API build is broken on 4.x branch (without this patch). |
dmatveev
approved these changes
Dec 16, 2022
Contributor
dmatveev
left a comment
There was a problem hiding this comment.
I am fine with this.. Thank you so much!
Contributor
We'll definitely look into this as there is some work to do for an upcoming OpenVINO release.. BTW standalone isn't tested now on CI, right? |
Member
Author
|
@dmatveev G-API standalone mode could be run with PRs on BuildBot CI using the old instructions: (but there is no regular testing for that) Logs with issues for this PR are here: |
Contributor
|
So let's merge it then? because why not? |
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
G-API: replace GAPI_Assert() with 'false' and '0' to GAPI_Error() * gapi: GAPI_Error() macro * gapi: replace GAPI_Assert() with 'false' and '0' to GAPI_Error() * build: eliminate 'unreachable code' after CV_Error() (MSVC 2015) * build: eliminate 'unreachable code' warning for MSVS 2015/2017 - observed in constructors stubs with throwing exception
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to eliminate build warnings about unreachable control flow (GCC 12)
relates #21496
Update rules:
TODO: