Conversation
Fixing Issue - opencv#22053 Inaccuracy in the tutorial for installation for Windows
| @code | ||
| setx -m OPENCV_DIR D:\OpenCV\Build\x86\vc11 (suggested for Visual Studio 2012 - 32 bit Windows) | ||
| setx -m OPENCV_DIR D:\OpenCV\Build\x64\vc11 (suggested for Visual Studio 2012 - 64 bit Windows) | ||
| setx OPENCV_DIR D:\OpenCV\Build\x86\vc11 (suggested for Visual Studio 2012 - 32 bit Windows) |
There was a problem hiding this comment.
double space between setx and OpenCV_DIR is not needed here and below.
Build
It is all lowercase build in modern versions of the package.
OPENCV_DIR
Modern CMake requests OpenCV_DIR. Case-insensitive support is a hack.
vc11 / vc12 are not supported anymore (compiler support is dropped in 2018 and OpenCV 4.x+).
Perhaps it should be updated to vc14 / vc15 (2017) / vc16 (2019).
Or even <platfrom>/<compiler> could be dropped too as there is automatic dispatcher for CMake on the top level (but we still need to pass the proper PATH somehow).
| different platform (e.g. x64 instead of x86) or compiler type, so substitute appropriate value. | ||
| Inside this, you should have two folders called *lib* and *bin*. The -m should be added if you wish | ||
| to make the settings computer wise, instead of user wise. | ||
| Inside this, you should have two folders called *lib* and *bin*. |
There was a problem hiding this comment.
-m option of setx command may be useful.
However we should not learn users how to deal with all Windows parameters in OpenCV docs, so removal is OK to me.
Changed all changes mentioned in the comments
alalek
left a comment
There was a problem hiding this comment.
Thank you for the contribution 👍
- x86 is optional and not available by default in packages
* Update windows_install.markdown Fixing Issue - opencv#22053 Inaccuracy in the tutorial for installation for Windows * Update windows_install.markdown opencv#22907 Changed all changes mentioned in the comments * Update windows_install.markdown opencv#22907 * fix whitespace, update configurations order (64-bit goes first) - x86 is optional and not available by default in packages
Fixes #22053
Fixing Issue - #22053 Inaccuracy in the tutorial for installation for Windows
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.