OpenEXR encoder: add capability to set the DWA compression level#22790
Merged
alalek merged 3 commits intoopencv:4.xfrom Nov 11, 2022
Merged
Conversation
… outside (cherry picked from commit aa276ec)
alalek
reviewed
Nov 10, 2022
| } | ||
| if (params[i] == IMWRITE_EXR_DWA_COMPRESSION_LEVEL) | ||
| { | ||
| header.dwaCompressionLevel() = params[i + 1]; |
Member
There was a problem hiding this comment.
Need to add compile-time version check here (through #if)
Contributor
Author
There was a problem hiding this comment.
Correct, added checks. DWA compression should be available since version 2.2, didn't realize that there may still be older versions out there.
Contributor
Author
There was a problem hiding this comment.
Oops, looks like the setting itself is available only from version 3 on.
…ersion 3 or later
147b53e to
9494b9e
Compare
alalek
reviewed
Nov 11, 2022
modules/imgcodecs/src/grfmt_exr.cpp
Outdated
| #if defined(OPENEXR_VERSION_MAJOR) && OPENEXR_VERSION_MAJOR >= 3 | ||
| header.dwaCompressionLevel() = params[i + 1]; | ||
| #elif defined(OPENEXR_VERSION_MAJOR) | ||
| throw std::runtime_error("Setting `IMWRITE_EXR_DWA_COMPRESSION_LEVEL` not supported in OpenEXR version " + std::to_string(OPENEXR_VERSION_MAJOR) + " (version 3 is required)"); |
Member
There was a problem hiding this comment.
throw std::runtime_error
Lets use CV_LOG_ONCE_WARNING(NULL, "message"); instead to keep existed behavior for unknown/unsupported hints.
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
…WA-compression-level-in-OpenEXR-encoding OpenEXR encoder: add capability to set the DWA compression level * OpenEXR encoder: add capability to set the DWA compression level from outside * Do not try to call `header.dwaCompressionLevel()` if OpenEXR is not version 3 or later * Minor cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extracted from #21324
(cherry picked from commit aa276ec)
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.