Skip to content

Aspect ratio fix for fisheye camera matrix estimation#22604

Closed
savuor wants to merge 1 commit intoopencv:4.xfrom
savuor:fix_fisheye_aspect_ratio
Closed

Aspect ratio fix for fisheye camera matrix estimation#22604
savuor wants to merge 1 commit intoopencv:4.xfrom
savuor:fix_fisheye_aspect_ratio

Conversation

@savuor
Copy link
Copy Markdown
Contributor

@savuor savuor commented Oct 6, 2022 •
edited
Loading

Fixes #22537

Connected PR in extra: #1028@extra

TODOs:

  • Make backport for 3.x

Changes

  • A bug looks like a typo, fixed
  • Do not write correct image file to test data, read it instead
  • Do not write anything without --test_debug flag
  • Java test fixed too & enabled (no reason why it was turned off)

Notes

Unfortunately, we (me and the issue author) have no idea on how to reproduce the bug: fisheye cameras with significantly non-square pixels are not that popular, fixed new values instead.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@savuor savuor mentioned this pull request Oct 6, 2022
Closed
6 tasks
@asmorkalov asmorkalov requested a review from vpisarev October 7, 2022 05:59
@asmorkalov asmorkalov added this to the 4.7.0 milestone Oct 7, 2022
@asmorkalov asmorkalov added bug port/backport done Label for maintainers. Authors of PR can ignore this labels Oct 7, 2022
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Oct 7, 2022

@savuor

[  FAILED  ] fisheyeTest.stereoRectify (0 ms)

@savuor savuor force-pushed the fix_fisheye_aspect_ratio branch from 36f034a to bf72dd3 Compare December 22, 2022 01:22
@savuor savuor mentioned this pull request Dec 23, 2022
Closed
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Dec 23, 2022

@savuor Please rebase the PR to 4.x, retarget it to 4.x and fix CI issues. It'll be merged to 5.x after release. It's urgent!

@asmorkalov asmorkalov modified the milestones: 4.7.0, 3.4.19 Dec 23, 2022
@asmorkalov asmorkalov force-pushed the fix_fisheye_aspect_ratio branch from 01c338c to 6f4b5c5 Compare December 23, 2022 11:43
@asmorkalov asmorkalov changed the base branch from 5.x to 4.x December 23, 2022 11:43
@asmorkalov asmorkalov removed the port/backport done Label for maintainers. Authors of PR can ignore this label Dec 23, 2022
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Dec 23, 2022

Squashed and re-targeted to 4.x.

@asmorkalov asmorkalov modified the milestones: 3.4.19, 4.7.0 Dec 23, 2022
@asmorkalov asmorkalov added backport is needed Label for maintainers. Authors of PR can ignore this affected: 3.4 labels Dec 23, 2022
@asmorkalov asmorkalov force-pushed the fix_fisheye_aspect_ratio branch from 6f4b5c5 to 1591a7f Compare December 23, 2022 12:45
@asmorkalov asmorkalov mentioned this pull request Dec 23, 2022
Closed
6 tasks
asmorkalov added a commit to asmorkalov/opencv that referenced this pull request Dec 23, 2022
@asmorkalov
Backport of opencv#22604 with FishEye aspect ration fix.
e8e9195
@asmorkalov asmorkalov added port/backport done Label for maintainers. Authors of PR can ignore this and removed backport is needed Label for maintainers. Authors of PR can ignore this labels Dec 23, 2022
This was referenced Dec 24, 2022
Closed
Merged
@savuor savuor force-pushed the fix_fisheye_aspect_ratio branch from 4c232ca to 84fb474 Compare December 27, 2022 00:03
@alalek alalek mentioned this pull request Dec 27, 2022
Merged
@alalek
Copy link
Copy Markdown
Member

alalek commented Dec 27, 2022

Merged through #23042

@savuor savuor deleted the fix_fisheye_aspect_ratio branch December 28, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vpisarev vpisarev vpisarev approved these changes

Assignees

@vpisarev vpisarev

Labels

affected: 3.4 bug category: calib3d port/backport done Label for maintainers. Authors of PR can ignore this

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

Possible mistake in source code of function cv::fisheye::estimateNewCameraMatrixForUndistortRectify

4 participants

@savuor @asmorkalov @alalek @vpisarev