Skip to content

DNN: Let Slice layer support non-sequential and negative axes#22554

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
WanliZhong:slice_axes_no_seq
Oct 3, 2022
Merged

DNN: Let Slice layer support non-sequential and negative axes#22554
asmorkalov merged 1 commit intoopencv:4.xfrom
WanliZhong:slice_axes_no_seq

Conversation

@WanliZhong
Copy link
Copy Markdown
Member

@WanliZhong WanliZhong commented Sep 22, 2022 •
edited
Loading

Merge with extra: opencv/opencv_extra#1008

This PR try to fix #22355.
ONNX operator doc: https://github.com/onnx/onnx/blob/main/docs/Operators.md#Slice

  • Support non-sequential axes input
  • Support negative number of axes

TODO:

  • Reduce duplicated code
  • Add test for this enhancement

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added category: dnn category: dnn (onnx) ONNX suport issues in DNN module labels Sep 22, 2022
@WanliZhong WanliZhong mentioned this pull request Sep 23, 2022
Merged
@fengyuentau fengyuentau self-requested a review September 25, 2022 12:22
@WanliZhong WanliZhong marked this pull request as ready for review September 27, 2022 07:49
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Sep 30, 2022

@fengyuentau friendly reminder.

@asmorkalov asmorkalov requested a review from rogday September 30, 2022 07:35
fengyuentau
fengyuentau reviewed Sep 30, 2022
View reviewed changes
fengyuentau
fengyuentau reviewed Sep 30, 2022
View reviewed changes
fengyuentau
fengyuentau approved these changes Sep 30, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@fengyuentau fengyuentau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

rogday
rogday approved these changes Sep 30, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@rogday rogday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good.

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Sep 30, 2022

@WanliZhong please squash commits before merge.

@WanliZhong
enhance slice layer
4557971 
refactor the code for parsing Slice layer
add test for Slice layer
let 'begin' and 'end' resize to dims
add opset message comment
@WanliZhong
Copy link
Copy Markdown
Member Author

WanliZhong commented Oct 1, 2022

@asmorkalov I've done and this pr is ready to be merged. Thanks!

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Oct 3, 2022

@WanliZhong Thanks! The PR looks good to me and is ready for merge. Please fix issues in related extra PR. I need to merge them together.

@asmorkalov asmorkalov merged commit 96844b0 into opencv:4.x Oct 3, 2022
@asmorkalov asmorkalov mentioned this pull request Dec 1, 2022
Closed
@alalek alalek mentioned this pull request Jan 8, 2023
Merged
@asmorkalov asmorkalov added this to the 4.7.0 milestone Jan 23, 2023
@WanliZhong WanliZhong deleted the slice_axes_no_seq branch May 16, 2023 12:33
savuor pushed a commit to nickyu-zhu/opencv that referenced this pull request Oct 27, 2023
@WanliZhong
addtest for PR opencv#22554
17f8efd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fengyuentau fengyuentau fengyuentau approved these changes

+1 more reviewer

@rogday rogday rogday approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

category: dnn (onnx) ONNX suport issues in DNN module category: dnn

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

dnn module: problem when importing ONNX model

4 participants

@WanliZhong @asmorkalov @fengyuentau @rogday