G-API Expose all core operations to python by TolyaTalamanov · Pull Request #22494 · opencv/opencv

TolyaTalamanov · 2022-09-10T18:31:16Z

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
The PR is proposed to the proper branch
There is a reference to the original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

Motivation

Python bindings are available since a long time, but only a few operations (operation::on(...) wrappers) were exposed.
There was a great plan to implement feature in python parser that could automatically detect G-API operation (via GAPI_TYPED_KERNEL macro or so) and expose it into python, but this functionality is more about giving an opportunity to user to implement python kernels for already existing in G-API operations.

This PR is going to expose just operation::on wrappers to python in order to give user everything that is available from c++, because now, for developers who don't build from source and change the code only available a small amount of functionality.
Since a lot of developers use opencv from pip let's expose it once and forever.

Great example of G-API usage: https://github.com/xiong-jie-y/g_api_examples

TODO list:

TolyaTalamanov · 2022-09-11T11:35:24Z

modules/gapi/include/opencv2/gapi/imgproc.hpp

 */
-GAPI_EXPORTS GMat blur(const GMat& src, const Size& ksize, const Point& anchor = Point(-1,-1),
-                       int borderType = BORDER_DEFAULT, const Scalar& borderValue = Scalar(0));
+GAPI_EXPORTS_W GMat blur(const GMat& src, const Size& ksize, const Point& anchor = Point(-1,-1),


Exception from core operations, just want it to be exposed asap :)

TolyaTalamanov · 2022-09-11T11:37:26Z

modules/gapi/include/opencv2/gapi/core.hpp

 @note Function textual ID is "org.opencv.core.kmeans3D"
 */
-GAPI_EXPORTS std::tuple<GOpaque<double>,GArray<int>,GArray<Point3f>>
+GAPI_EXPORTS_W std::tuple<GOpaque<double>,GArray<int>,GArray<Point3f>>


Make sense to add test for this one because it touches a lot of existing functionality.

kmeans or what?

Yes, add test for kmeans because it returns Point3f which wasn't supported before

TolyaTalamanov · 2022-09-11T11:45:15Z

@dmatveev Could you have a look, please?

dmatveev

We need to do something with all that our type enumerations in all these different headers... Worth a TODO

dmatveev · 2022-09-15T19:05:27Z

modules/gapi/include/opencv2/gapi/core.hpp

 @note Function textual ID is "org.opencv.core.kmeans3D"
 */
-GAPI_EXPORTS std::tuple<GOpaque<double>,GArray<int>,GArray<Point3f>>
+GAPI_EXPORTS_W std::tuple<GOpaque<double>,GArray<int>,GArray<Point3f>>


kmeans or what?

dmatveev · 2022-09-15T19:06:04Z

modules/gapi/include/opencv2/gapi/gcommon.hpp

        CV_STRING,     // std::string user G-API data
        CV_POINT,      // cv::Point user G-API data
        CV_POINT2F,    // cv::Point2f user G-API data
+        CV_POINT3F,    // cv::Point3f user G-API data


Missed the below type? See GOpaqueTraits

I didn't exposed it for purpose, because there weren't such cases

But it is an inconsistency now, isnt it?

And now its only you who knows the reason for it (ok, and me)

asmorkalov · 2022-10-11T07:11:05Z

@TolyaTalamanov Friendly reminder.

TolyaTalamanov · 2022-10-29T13:28:10Z

modules/gapi/include/opencv2/gapi/gcommon.hpp

        CV_STRING,     // std::string user G-API data
        CV_POINT,      // cv::Point user G-API data
        CV_POINT2F,    // cv::Point2f user G-API data
+        CV_POINT3F,    // cv::Point3f user G-API data


TolyaTalamanov · 2022-10-29T13:29:07Z

modules/gapi/misc/python/test/test_gapi_core.py

            self.assertEqual(K, len(centers))


+        def test_kmeans_3d(self):


Actually tests only functionality without accuracy checking with ocv

TolyaTalamanov · 2022-10-29T13:29:44Z

@dmatveev Could you have a look, please?

dmatveev

👍

TolyaTalamanov · 2022-10-30T12:32:51Z

@asmorkalov Can it be merged?

TolyaTalamanov · 2022-11-08T07:46:59Z

@alalek @asmorkalov Could you merge it, please?

…e-to-python G-API Expose all core operations to python * Expose all G-API core operations to python * Fix typo in python gapi types test

TolyaTalamanov requested a review from dmatveev September 10, 2022 18:31

TolyaTalamanov commented Sep 11, 2022

View reviewed changes

asmorkalov added this to the 4.7.0 milestone Sep 13, 2022

asmorkalov assigned dmatveev Sep 13, 2022

dmatveev reviewed Sep 15, 2022

View reviewed changes

TolyaTalamanov changed the title ~~WIP: G-API Expose all core operations to python~~ G-API Expose all core operations to python Oct 29, 2022

TolyaTalamanov force-pushed the at/expose-all-core-to-python branch from e567339 to 2b601de Compare October 29, 2022 13:24

Expose all G-API core operations to python

f8eca04

TolyaTalamanov force-pushed the at/expose-all-core-to-python branch from 2b601de to f8eca04 Compare October 29, 2022 13:27

TolyaTalamanov commented Oct 29, 2022

View reviewed changes

dmatveev approved these changes Oct 29, 2022

View reviewed changes

Fix typo in python gapi types test

4ab6cbb

alalek merged commit 2aad039 into opencv:4.x Nov 8, 2022

alalek mentioned this pull request Jan 8, 2023

(5.x) Merge 4.x #23113

Merged

Uh oh!

Conversation

TolyaTalamanov commented Sep 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Readiness Checklist

Motivation

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TolyaTalamanov commented Sep 11, 2022

Uh oh!

dmatveev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmatveev Sep 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

asmorkalov commented Oct 11, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TolyaTalamanov commented Oct 29, 2022

Uh oh!

dmatveev left a comment

Choose a reason for hiding this comment

Uh oh!

TolyaTalamanov commented Oct 30, 2022

Uh oh!

TolyaTalamanov commented Nov 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TolyaTalamanov commented Sep 10, 2022 •

edited

Loading

dmatveev Sep 16, 2022 •

edited

Loading