G-API: Bump ADE to version 0.1.2#22396
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Aug 18, 2022
Merged
Conversation
TolyaTalamanov
approved these changes
Aug 18, 2022
Contributor
TolyaTalamanov
left a comment
There was a problem hiding this comment.
Thank you. LGTM 👍
| set(ade_md5 "b624b995ec9c439cbc2e9e6ee940d3a2") | ||
| set(ade_filename "v0.1.2.zip") | ||
| set(ade_subdir "ade-0.1.2") | ||
| set(ade_md5 "561c1e28ccf27ad0557a18e251c22226") |
Contributor
There was a problem hiding this comment.
Have no clue how it works :(
Is it possible to find this checksum somewhere else to check if it matches?
Member
|
There are several build warnings after this patch: http://pullrequest.opencv.org/buildbot/builders/master-win64-vc14/builds/100006 (MSVS 2015) |
Merged
4 tasks
ShuangLiu1992
pushed a commit
to ShuangLiu1992/opencv
that referenced
this pull request
Sep 19, 2022
G-API: Bump ADE to version 0.1.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a number of issues fixed in ADE recently, mainly about new compiler support + various build options were added.
Bumping ADE in OpenCV resolves #21109
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.