Skip to content

QRcode, change INTER_LINEAR to INTER_LINEAR_EXACT#22358

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
AleksandrPanov:qrcode_x86_arm
Sep 29, 2022
Merged

QRcode, change INTER_LINEAR to INTER_LINEAR_EXACT#22358
asmorkalov merged 1 commit intoopencv:4.xfrom
AleksandrPanov:qrcode_x86_arm

Conversation

@AleksandrPanov
Copy link
Copy Markdown
Contributor

@AleksandrPanov AleksandrPanov commented Aug 9, 2022 •
edited
Loading

fixes #22133
merge with opencv/opencv_extra#992

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@AleksandrPanov AleksandrPanov added bug test category: objdetect platform: arm ARM boards related issues: RPi, NVIDIA TK/TX, etc labels Aug 9, 2022
@AleksandrPanov AleksandrPanov force-pushed the qrcode_x86_arm branch 2 times, most recently from 38677a6 to cd71c5d Compare August 9, 2022 04:09
@AleksandrPanov AleksandrPanov mentioned this pull request Aug 11, 2022
Merged
@AleksandrPanov AleksandrPanov force-pushed the qrcode_x86_arm branch 3 times, most recently from 394a8a1 to 60e188b Compare August 11, 2022 02:54
@AleksandrPanov AleksandrPanov marked this pull request as ready for review August 11, 2022 04:05
asmorkalov
asmorkalov approved these changes Aug 11, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good for me, but fixes in extra part are required.

@AleksandrPanov AleksandrPanov force-pushed the qrcode_x86_arm branch 2 times, most recently from 1978eaf to 2fc4578 Compare August 11, 2022 22:00
@asmorkalov asmorkalov self-assigned this Aug 12, 2022
@asmorkalov asmorkalov added the pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch label Aug 12, 2022
@asmorkalov asmorkalov self-requested a review August 12, 2022 08:08
@AleksandrPanov
Copy link
Copy Markdown
Contributor Author

AleksandrPanov commented Aug 15, 2022 •
edited
Loading

@asmorkalov, I opened a new PR for 3.4. There are differences in the code for 3.4 (another number of resize() calls). After merge #22382 to 4.x need to merge #22358.

@asmorkalov asmorkalov removed the pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch label Aug 15, 2022
change resize flag INTER_LINEAR to INTER_LINEAR_EXACT
d43cb4f 
fix python test_detect_and_decode_multi, sort QR in multiDetect/multiDecode
enable tests with "version_5_up.jpg", "version_5_top.jpg"
asmorkalov
asmorkalov approved these changes Sep 29, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit adb916c into opencv:4.x Sep 29, 2022
@alalek alalek mentioned this pull request Jan 8, 2023
Merged
@asmorkalov asmorkalov added this to the 4.7.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

affected: 3.4 bug category: objdetect platform: arm ARM boards related issues: RPi, NVIDIA TK/TX, etc test

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

detectMulti() x86-64 and detectMulti() ARM64 work differently in QRCodeDetector in some cases (problem with resize)

2 participants

@AleksandrPanov @asmorkalov