Skip to content

Add zoom factor to interactive calibration tool#22147

Merged
alalek merged 2 commits intoopencv:4.xfrom
rogday:zoom_factor
Jun 30, 2022
Merged

Add zoom factor to interactive calibration tool#22147
alalek merged 2 commits intoopencv:4.xfrom
rogday:zoom_factor

Conversation

@rogday
Copy link
Copy Markdown
Member

@rogday rogday commented Jun 22, 2022

Can be useful when the screen is smaller than the image from camera.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@rogday rogday added feature category: apps OpenCV builtin tools labels Jun 22, 2022
@asmorkalov asmorkalov self-requested a review June 22, 2022 13:26
asmorkalov
asmorkalov approved these changes Jun 22, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rogday rogday marked this pull request as ready for review June 22, 2022 14:08
@asmorkalov asmorkalov self-requested a review June 23, 2022 06:31
alalek
alalek reviewed Jun 23, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to call putText() after the frame's resize.
Or resize input frames after its capture as the first step.

@rogday
Copy link
Copy Markdown
Member Author

rogday commented Jun 29, 2022

It makes sense to call putText() after the frame's resize. Or resize input frames after its capture as the first step.

I don't think putText() is the offender here - board detection is much more computationally expensive. The purpose of this PR is for the camera output to fit onto the screen. If we resize the frames first, I believe the results of the calibration will differ, and small boards (or boards that are too far) won't be detected anymore.

@alalek
Copy link
Copy Markdown
Member

alalek commented Jun 29, 2022

I agreed, that resizing of input frames is a bad idea (just because we don't get intrinsics for original resolution).

But I still believe that putText() should be done after the resize operation (to keep UI messages clear).

@asmorkalov asmorkalov self-requested a review June 30, 2022 08:01
@alalek alalek merged commit b91f173 into opencv:4.x Jun 30, 2022
@rogday rogday mentioned this pull request Jul 24, 2022
Merged
6 tasks
@alalek alalek mentioned this pull request Aug 21, 2022
Merged
@rogday rogday deleted the zoom_factor branch October 18, 2022 14:06
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@rogday
Merge pull request opencv#22147 from rogday:zoom_factor
0554f86 
Add zoom factor to interactive calibration tool

* add zoom factor

* address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek left review comments

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: apps OpenCV builtin tools feature

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@rogday @alalek @asmorkalov