Optimize the cvCeil and cvFloor functions for LoongArch#22040
Optimize the cvCeil and cvFloor functions for LoongArch#22040asmorkalov merged 1 commit intoopencv:4.xfrom
Conversation
|
Relates to #21833 |
|
@CNClareChen, thank you! I wonder, if |
@vpisarev thanks， these _builtin finterfaces are not currently integrated in the compiler for the LoongArch platform. Therefore, in OpencV I use the way of embedded assembly to achieve these functions quickly. |
|
@CNClareChen @fengyuentau The base PR for loongArch support has been merged. Please rebase the PR and fix merge conflicts. |
|
@fengyuentau Could you sqaush commits? "Merge branch '4.x' into 4.x" - it'll be merged to history too. |
|
I could but I do not know the safe way to do this without dropping @CNClareChen 's status as a contributor. |
|
@CNClareChen could you squash commits on your side? |
|
OK, thanks for reminding me. I'll deal with it tomorrow.---- Replied Message ----FromAlexander ***@***.***>Date09/12/2022 16:31 ***@***.***> ***@***.******@***.***>SubjectRe: [opencv/opencv] Optimize the cvCeil and cvFloor functions for LoongArch (PR #22040)
@CNClareChen could you squash commits on your side?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
[
{
***@***.***": "http://schema.org",
***@***.***": "EmailMessage",
"potentialAction": {
***@***.***": "ViewAction",
"target": "#22040 (comment)",
"url": "#22040 (comment)",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
***@***.***": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
|
|
@asmorkalov Now, this patch is merged. Should I resubmit a patch to modifies the commits? |
This patch optimizes the cvCeil and cvFloor functions on the LoongArch platform. Signed-off-by: Hao Chen <chenhao@loongson.cn>
|
@CNClareChen I apologize, I disoriented you. Yuantao merged upstream 4.x to your branch, but not rebase it. It leads to incompatible commit history in you branch and upstream. I fixed the issue by cherry-picking of proper commit on top of upstream 4.x. Please pay attention, that I have to rewrite commits history for it. Please chech the branch with real hardware to ensure the patch works correctly. |
|
Tested on loongarch server and all tests are passed except the known |
Thank you very much for your kind help. This patch can work normally in my branch with real hardware. |
This patch optimizes the cvCeil and cvFloor functions on
the LoongArch platform.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.