Skip to content

Add undistortImagePoints function#21931

Merged
opencv-pushbot merged 4 commits intoopencv:4.xfrom
victor1234:calib3d-add-undistortImagePoints
May 12, 2022
Merged

Add undistortImagePoints function#21931
opencv-pushbot merged 4 commits intoopencv:4.xfrom
victor1234:calib3d-add-undistortImagePoints

Conversation

@victor1234
Copy link
Copy Markdown
Contributor

@victor1234 victor1234 commented Apr 29, 2022

cv::undistortPoints() has unclear interface and additional functionality. New function computes only undistorted image points position

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@victor1234 victor1234 self-assigned this Apr 29, 2022
@victor1234
Add undistortImagePoints function
0f2287a 
undistortPoints has unclear interface and additional functionality. New function computes only undistorted image points position
@victor1234 victor1234 force-pushed the calib3d-add-undistortImagePoints branch from 74d77e2 to 0f2287a Compare May 4, 2022 17:24
@victor1234 victor1234 marked this pull request as ready for review May 5, 2022 07:50
@victor1234 victor1234 requested a review from asmorkalov May 5, 2022 07:50
asmorkalov
asmorkalov reviewed May 5, 2022
View reviewed changes
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented May 5, 2022

https://pullrequest.opencv.org/buildbot/builders/precommit_docs/builds/100146/steps/whitespace%20opencv/logs/stdio

@asmorkalov asmorkalov self-requested a review May 6, 2022 05:48
asmorkalov
asmorkalov approved these changes May 6, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@opencv-pushbot opencv-pushbot added this to the 4.6.0 milestone May 12, 2022
@opencv-pushbot opencv-pushbot merged commit 2b67bc4 into opencv:4.x May 12, 2022
@victor1234 victor1234 deleted the calib3d-add-undistortImagePoints branch May 23, 2022 11:29
@alalek alalek mentioned this pull request Aug 21, 2022
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@victor1234
Merge pull request opencv#21931 from victor1234:calib3d-add-undistort…
e87ca01 
…ImagePoints

Add undistortImagePoints function

* Add undistortImagePoints function
undistortPoints has unclear interface and additional functionality. New function computes only undistorted image points position

* Add undistortImagePoints test

* Add TermCriteria

* Fix layout
@saolaolsson saolaolsson mentioned this pull request Nov 18, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@opencv-pushbot opencv-pushbot

Labels

category: calib3d feature

Projects

None yet

Milestone

4.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@victor1234 @asmorkalov @opencv-pushbot