Merged
Conversation
…om/dbudnikov/opencv into dbudnikov/reduce_gapi_tests_number
Contributor
Author
|
These changes reduce overall number of G-API tests by ~25% and overall G-API test suite execution time by ~20%. |
dmatveev
approved these changes
Apr 29, 2022
Contributor
dmatveev
left a comment
There was a problem hiding this comment.
If we still have cases with multiple resolutions, I'd propose to declare a constant vector of the sizes once and for all tests - and use ValuesIn(...) in the test instantiations
Comment on lines
21
to
-23
| Values(cv::Size(1920, 1080), | ||
| cv::Size(1280, 720), | ||
| cv::Size(640, 480), |
Contributor
There was a problem hiding this comment.
This selection looks strange. Shouldn't the 1080 option be removed & 720 be kept as in the previous file?
As far I can see, the below cases also instantiate 720 and not 1080.
Comment on lines
243
to
244
| Values(cv::Size(1920, 1080), | ||
| cv::Size(1280, 720), | ||
| cv::Size(640, 480), | ||
| cv::Size(128, 128)), |
Contributor
There was a problem hiding this comment.
Maybe we should declare the list of resolutions we test one and for all the tests? Then ValuesIn(...) could be used.
ebed694 to
18ca503
Compare
18ca503 to
1f9882b
Compare
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
…tests_number Reduce G-API tests number * reduce number of G-API tests * reduce number of G-API tests * Address more comments from Dmitry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.