Skip to content

Fix CUDA compilation issues and adjust thresholds.#21884

Merged
opencv-pushbot merged 2 commits intoopencv:4.xfrom
rogday:cuda_cleanup
Apr 19, 2022
Merged

Fix CUDA compilation issues and adjust thresholds.#21884
opencv-pushbot merged 2 commits intoopencv:4.xfrom
rogday:cuda_cleanup

Conversation

@rogday
Copy link
Copy Markdown
Member

@rogday rogday commented Apr 18, 2022

Related #21831

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Apr 19, 2022 

[  PASSED  ] 11817 tests.
[  FAILED  ] 15 tests, listed below:
[  FAILED  ] Test_ONNX_conformance.Layer_Test/test_reduce_prod_default_axes_keepdims_example_CUDA_CUDA_FP16, where GetParam() = (test_reduce_prod_default_axes_keepdims_example, CUDA/CUDA_FP16)
[  FAILED  ] Test_ONNX_conformance.Layer_Test/test_reduce_prod_default_axes_keepdims_random_CUDA_CUDA_FP16, where GetParam() = (test_reduce_prod_default_axes_keepdims_random, CUDA/CUDA_FP16)
[  FAILED  ] Test_ONNX_conformance.Layer_Test/test_reduce_prod_do_not_keepdims_random_CUDA_CUDA_FP16, where GetParam() = (test_reduce_prod_do_not_keepdims_random, CUDA/CUDA_FP16)
[  FAILED  ] Test_ONNX_conformance.Layer_Test/test_reduce_prod_keepdims_random_CUDA_CUDA_FP16, where GetParam() = (test_reduce_prod_keepdims_random, CUDA/CUDA_FP16)
[  FAILED  ] Test_ONNX_conformance.Layer_Test/test_reduce_prod_negative_axes_keepdims_random_CUDA_CUDA_FP16, where GetParam() = (test_reduce_prod_negative_axes_keepdims_random, CUDA/CUDA_FP16)
[  FAILED  ] Test_ONNX_conformance.Layer_Test/test_reduce_sum_square_default_axes_keepdims_random_CUDA_CUDA_FP16, where GetParam() = (test_reduce_sum_square_default_axes_keepdims_random, CUDA/CUDA_FP16)
[  FAILED  ] Test_ONNX_conformance.Layer_Test/test_reduce_sum_square_do_not_keepdims_random_CUDA_CUDA_FP16, where GetParam() = (test_reduce_sum_square_do_not_keepdims_random, CUDA/CUDA_FP16)
[  FAILED  ] Test_ONNX_conformance.Layer_Test/test_reduce_sum_square_keepdims_random_CUDA_CUDA_FP16, where GetParam() = (test_reduce_sum_square_keepdims_random, CUDA/CUDA_FP16)
[  FAILED  ] Test_ONNX_conformance.Layer_Test/test_reduce_sum_square_negative_axes_keepdims_random_CUDA_CUDA_FP16, where GetParam() = (test_reduce_sum_square_negative_axes_keepdims_random, CUDA/CUDA_FP16)
[  FAILED  ] Test_ONNX_layers.Convolution3D/1, where GetParam() = CUDA/CUDA_FP16
[  FAILED  ] Test_ONNX_layers.Convolution3D_bias/1, where GetParam() = CUDA/CUDA_FP16
[  FAILED  ] Test_ONNX_layers.PoolConv3D/1, where GetParam() = CUDA/CUDA_FP16
[  FAILED  ] Test_ONNX_nets.Resnet34_kinetics/1, where GetParam() = CUDA/CUDA_FP16
[  FAILED  ] Test_TensorFlow_layers.Convolution3D/1, where GetParam() = CUDA/CUDA_FP16
[  FAILED  ] Test_TensorFlow_layers.concat_3d/1, where GetParam() = CUDA/CUDA_FP16

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Apr 19, 2022

Well done!

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Apr 19, 2022 

[==========] 6920 tests from 79 test cases ran. (128751 ms total)
[  PASSED  ] 6920 tests.

@asmorkalov asmorkalov self-requested a review April 19, 2022 14:56
@opencv-pushbot opencv-pushbot added the category: gpu/cuda (contrib) OpenCV 4.0+: moved to opencv_contrib label Apr 19, 2022
@opencv-pushbot opencv-pushbot added this to the 4.6.0 milestone Apr 19, 2022
@opencv-pushbot opencv-pushbot merged commit 9cd5a0a into opencv:4.x Apr 19, 2022
@rogday rogday deleted the cuda_cleanup branch April 19, 2022 18:29
@opencv-pushbot opencv-pushbot mentioned this pull request Apr 23, 2022
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@rogday
Merge pull request opencv#21884 from rogday:cuda_cleanup
b649495 
Fix CUDA compilation issues and adjust thresholds.

* Fix CUDA compilation issues and adjust thresholds.

* add conformance tests to denylist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

bug category: dnn category: gpu/cuda (contrib) OpenCV 4.0+: moved to opencv_contrib

Projects

None yet

Milestone

4.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@rogday @asmorkalov @opencv-pushbot