Skip to content

Add termination criteria to cv::fisheye::undistortPoints()#21834

Merged
opencv-pushbot merged 2 commits intoopencv:4.xfrom
victor1234:issue-19138_add_termcriteria_to_fisheye_undistortpoints
Apr 16, 2022
Merged

Add termination criteria to cv::fisheye::undistortPoints()#21834
opencv-pushbot merged 2 commits intoopencv:4.xfrom
victor1234:issue-19138_add_termcriteria_to_fisheye_undistortpoints

Conversation

@victor1234
Copy link
Copy Markdown
Contributor

@victor1234 victor1234 commented Apr 7, 2022

Pull Request Readiness Checklist

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

#19138

Wrap hardcoded termination criteria to cv::TermCriteria with default values from code

@victor1234 victor1234 changed the title Add termination criteria to cv::fisheye::undistortPoints() Draft: Add termination criteria to cv::fisheye::undistortPoints() Apr 7, 2022
@victor1234 victor1234 changed the title Draft: Add termination criteria to cv::fisheye::undistortPoints() Add termination criteria to cv::fisheye::undistortPoints() Apr 7, 2022
@victor1234 victor1234 marked this pull request as draft April 7, 2022 16:22
@victor1234 victor1234 requested a review from vpisarev April 7, 2022 19:54
@victor1234 victor1234 self-assigned this Apr 7, 2022
asmorkalov
asmorkalov requested changes Apr 8, 2022
View reviewed changes
@victor1234 victor1234 marked this pull request as ready for review April 12, 2022 11:47
@asmorkalov asmorkalov self-requested a review April 12, 2022 12:03
asmorkalov
asmorkalov approved these changes Apr 12, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Apr 12, 2022

/cc @vpisarev Please lay attention on API change.

@opencv-pushbot opencv-pushbot added this to the 4.6.0 milestone Apr 16, 2022
@opencv-pushbot opencv-pushbot merged commit 27c15be into opencv:4.x Apr 16, 2022
@victor1234 victor1234 deleted the issue-19138_add_termcriteria_to_fisheye_undistortpoints branch April 18, 2022 08:48
@opencv-pushbot opencv-pushbot mentioned this pull request Apr 23, 2022
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@victor1234
Merge pull request opencv#21834 from victor1234:issue-19138_add_termc…
a7ec964 
…riteria_to_fisheye_undistortpoints

* Add termination criteria to cv::fisheye::undistortPoints()

* Add criteria.type check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vpisarev vpisarev vpisarev approved these changes

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@opencv-pushbot opencv-pushbot

Labels

category: calib3d

Projects

None yet

Milestone

4.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@victor1234 @asmorkalov @vpisarev @opencv-pushbot