Skip to content

Mat pretty printer: fix submatrix indexation#21805

Merged
opencv-pushbot merged 2 commits intoopencv:4.xfrom
rogday:pretty_fix
Apr 20, 2022
Merged

Mat pretty printer: fix submatrix indexation#21805
opencv-pushbot merged 2 commits intoopencv:4.xfrom
rogday:pretty_fix

Conversation

@rogday
Copy link
Copy Markdown
Member

@rogday rogday commented Apr 1, 2022

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@rogday rogday added the bug label Apr 1, 2022
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Apr 4, 2022

/cc @victor1234

@rogday rogday marked this pull request as draft April 4, 2022 08:02
@victor1234
Copy link
Copy Markdown
Contributor

victor1234 commented Apr 4, 2022

Add some comments for changes, pls

@rogday rogday marked this pull request as ready for review April 4, 2022 11:33
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Apr 11, 2022

/cc @sergregory

AleksandrPanov
AleksandrPanov approved these changes Apr 15, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@AleksandrPanov AleksandrPanov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there is still a problem with multi-channel Mat. I think that this problem should be fixed in another PR.

@rogday rogday marked this pull request as draft April 15, 2022 13:25
AleksandrPanov
AleksandrPanov approved these changes Apr 19, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@AleksandrPanov AleksandrPanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multi-channel works now 👍 👍 👍

@rogday rogday marked this pull request as ready for review April 20, 2022 00:24
@opencv-pushbot opencv-pushbot merged commit 438fe3f into opencv:4.x Apr 20, 2022
@rogday rogday deleted the pretty_fix branch April 20, 2022 07:08
@opencv-pushbot opencv-pushbot mentioned this pull request Apr 23, 2022
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@rogday
Merge pull request opencv#21805 from rogday:pretty_fix
7c9534d 
Mat pretty printer: fix submatrix indexation

* fix submatrix indexation

* fix channels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AleksandrPanov AleksandrPanov AleksandrPanov approved these changes

Assignees

@opencv-pushbot opencv-pushbot

Labels

bug category: samples

Projects

None yet

Milestone

4.6.0

Development

Successfully merging this pull request may close these issues.

6 participants

@rogday @asmorkalov @victor1234 @AleksandrPanov @opencv-pushbot @alalek