Skip to content

python binding for matches and inliers_mask attributes of cv2.detail_MatchesInfo class#21803

Merged
alalek merged 2 commits intoopencv:4.xfrom
oguzhanguclu:matches_info_pybinding
Apr 1, 2022
Merged

python binding for matches and inliers_mask attributes of cv2.detail_MatchesInfo class#21803
alalek merged 2 commits intoopencv:4.xfrom
oguzhanguclu:matches_info_pybinding

Conversation

@oguzhanguclu
Copy link
Copy Markdown
Contributor

In respect to the issue #21364, the pull request makes matches and inliers_mask attributes of the cv2.detail_MatchesInfo class accessible from python interface. By this way, developers could be able to make changes on the computed matches.

Pull Request Readiness Checklist

  • [Yes] I agree to contribute to the project under Apache 2 License.
  • [Yes] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • [Yes] The PR is proposed to the proper branch
  • [Yes] There is a reference to the original bug report and related work

@alalek
Copy link
Copy Markdown
Member

alalek commented Apr 1, 2022

Thank you for contribution!

Please add simple binding test here: https://github.com/opencv/opencv/blob/4.5.5/modules/stitching/misc/python/test/test_stitching.py (no need to check accuracy, just check fields and its types, check commits history of this file for similar examples)

@oguzhanguclu
Copy link
Copy Markdown
Contributor Author

I added the binding test, thanks.

Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Thank you for contribution 👍

@alalek alalek merged commit 38788a3 into opencv:4.x Apr 1, 2022
@oguzhanguclu oguzhanguclu deleted the matches_info_pybinding branch April 2, 2022 09:13
@opencv-pushbot opencv-pushbot mentioned this pull request Apr 23, 2022
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
python binding for matches and inliers_mask attributes of cv2.detail_MatchesInfo class

* making matches and inliers_mask attributes of cv2.detail_MatchesInfo class accessible from python interface

* binding test for cv2.detail_MatchesInfo class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants