Skip to content

GAPI: fix various gapi related typos#21775

Merged
opencv-pushbot merged 4 commits intoopencv:4.xfrom
luzpaz:typos/gapi
Apr 13, 2022
Merged

GAPI: fix various gapi related typos#21775
opencv-pushbot merged 4 commits intoopencv:4.xfrom
luzpaz:typos/gapi

Conversation

@luzpaz
Copy link
Copy Markdown
Contributor

@luzpaz luzpaz commented Mar 24, 2022

Fixes source code, comments, and documentation related to gapi code.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

// FIXME: If there are multiple sources in pipeline and one of them is live, then pipeline
// will return GST_STATE_CHANGE_NO_PREROLL while pipeline pausing.
// But appsink may not be connected to this live source and only to anothers,
// But appsink may not be connected to this live source and only to another,
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be another's ?


struct GAPI_EXPORTS DataProviderSystemErrorException final : public DataProviderException {
DataProviderSystemErrorException(int error_code, const std::string& desription = std::string());
DataProviderSystemErrorException(int error_code, const std::string& description = std::string());
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a source code change, please review closely

Copy link
Copy Markdown
Contributor

@sivanov-work sivanov-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

cap = cv::gapi::wip::make_onevpl_src(file_path, source_cfgs);
}
std::cout << "oneVPL source desription: " << cap->descr_of() << std::endl;
std::cout << "oneVPL source desrciption: " << cap->descr_of() << std::endl;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

desrciption -> description

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 44dd15c

@luzpaz
Copy link
Copy Markdown
Contributor Author

luzpaz commented Apr 11, 2022

Fixed and Rebased

@opencv-pushbot opencv-pushbot added this to the 4.6.0 milestone Apr 13, 2022
@opencv-pushbot opencv-pushbot merged commit 554d08c into opencv:4.x Apr 13, 2022
@luzpaz luzpaz deleted the typos/gapi branch April 13, 2022 17:25
@opencv-pushbot opencv-pushbot mentioned this pull request Apr 23, 2022
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
* GAPI: fix various gapi related typos

Fixes source comments and documentation related to gapi code.

* Fix source typos

* Fixed typos requested

* Follow-up typo fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants