Conversation
.github/workflows/extra_tests.yml
Outdated
| x86-simulator-build-test: | ||
| if: contains(github.event.pull_request.labels.*.name, 'category:dnn_timvx') | ||
| runs-on: ubuntu-20.04 | ||
| container: yuentau/ocv_ubuntu:20.04 |
There was a problem hiding this comment.
yuentau/ocv_ubuntu:20.04
Where is stored?
How is it generated?
There was a problem hiding this comment.
Reference added. Dockerfile can be accessed in the overview section of the linked Docker Hub repo.
There was a problem hiding this comment.
I make the source more clear: container: docker.io/yuentau/ocv_ubuntu:20.04. It works as the same with the one without docker.io/ prefix. You can verify by checking 'Initialize containers' from my test https://github.com/fengyuentau/github-actions-tests/runs/5653954490?check_suite_focus=true
| @@ -0,0 +1,104 @@ | |||
| name: TIM-VX Backend | |||
There was a problem hiding this comment.
.github/workflows/extra_tests.yml
Need to rename "extra_tests"
There was a problem hiding this comment.
Renamed to "timvx_backend_tests.yml". Or any suggestions?
…or_timvx_backend CI for TIM-VX backend * github actions for TIM-VX backend opencv#21036 * add reference to yuentau/ocv_ubuntu:20.04; remove extra quotes; enable BUILD_TESTS * rename to timvx_backend_tests.yml * add image source prefix * remove if condition for x86_64 simulator
Related PR: #21036
Docker image used for x86_64 simulator: https://hub.docker.com/r/yuentau/ocv_ubuntu
A running sample of this workflow on my fork: https://github.com/fengyuentau/opencv/actions/runs/2003773534
The yaml file must be on the default branch for GitHub to pick up and run the workflow. I propose to add the condition if for the two jobs before the PR for TIM-VX backend is merged. In this case, a new label "category:dnn_timvx" needs to be created for pull requests.
Also we need to add the Khadas VIM3 as the self-hosted runner to run the second job, which requires some operations by the admin.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.