add apply softmax option to ClassificationModel#21692
Merged
alalek merged 11 commits intoopencv:4.xfrom Mar 7, 2022
Merged
Conversation
Contributor
Author
|
dropped idea // Run Softmax defined inside ClassficationModel class
cv::dnn::ClassficationModel::softmax(input_blob, output_blob);
// Run Softmax defined outside ClassficationModel class
cv::dnn::softmax(input_blob, output_blob); |
alalek
reviewed
Mar 6, 2022
…onModel class" This reverts commit 67d845f.
alalek
approved these changes
Mar 7, 2022
Member
alalek
left a comment
There was a problem hiding this comment.
Well done! Thank you for contribution 👍
vpisarev
reviewed
Mar 11, 2022
| Mat exp; | ||
| const float max = *std::max_element(input.begin<float>(), input.end<float>()); | ||
| cv::exp((input - max), exp); | ||
| outblob.getMat() = exp / cv::sum(exp)[0]; |
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
* add apply softmax option to ClassificationModel * remove default arguments of ClassificationModel::setSoftMax() * fix build for python * fix docs warning for setSoftMax() * add impl for ClassficationModel() * fix failed build for docs by trailing whitespace * move to implement classify() to ClassificationModel_Impl * move to implement softmax() to ClassificationModel_Impl * remove softmax from public method in ClassificationModel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #21689
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.