Skip to content

[G-API] Pipeline modeling tool - support frame dropping for source#21636

Merged
alalek merged 3 commits intoopencv:4.xfrom
TolyaTalamanov:at/gapi_modeling_tool_drop_frames
Mar 15, 2022
Merged

[G-API] Pipeline modeling tool - support frame dropping for source#21636
alalek merged 3 commits intoopencv:4.xfrom
TolyaTalamanov:at/gapi_modeling_tool_drop_frames

Conversation

@TolyaTalamanov
Copy link
Copy Markdown
Contributor

@TolyaTalamanov TolyaTalamanov commented Feb 18, 2022

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Build configuration

force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

Xbuild_image:Custom=centos:7
Xbuildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

build_image:Custom=ubuntu-openvino-2021.4.1:20.04
build_image:Custom Win=openvino-2021.4.1
build_image:Custom Mac=openvino-2021.4.1

test_modules:Custom=gapi,python2,python3,java
test_modules:Custom Win=gapi,python2,python3,java
test_modules:Custom Mac=gapi,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

mpashchenkov
mpashchenkov approved these changes Feb 21, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@mpashchenkov mpashchenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. Thanks.

@dmatveev dmatveev self-assigned this Feb 24, 2022
@dmatveev dmatveev added this to the 4.6.0 milestone Feb 24, 2022
dmatveev
dmatveev reviewed Feb 24, 2022
View reviewed changes
rgarnov
rgarnov requested changes Feb 24, 2022
View reviewed changes
@TolyaTalamanov TolyaTalamanov force-pushed the at/gapi_modeling_tool_drop_frames branch 2 times, most recently from ff2a186 to 15df738 Compare March 9, 2022 12:37
@TolyaTalamanov TolyaTalamanov force-pushed the at/gapi_modeling_tool_drop_frames branch from 15df738 to d544cb6 Compare March 9, 2022 12:38
rgarnov
rgarnov requested changes Mar 11, 2022
View reviewed changes
@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Mar 14, 2022

@rgarnov Could you have a look, please?

@TolyaTalamanov TolyaTalamanov requested a review from rgarnov March 14, 2022 12:07
dmatveev
dmatveev approved these changes Mar 15, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alalek alalek merged commit e5f2a8e into opencv:4.x Mar 15, 2022
@opencv-pushbot opencv-pushbot mentioned this pull request Apr 23, 2022
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@TolyaTalamanov
Merge pull request opencv#21636 from TolyaTalamanov:at/gapi_modeling_…
0722e69 
…tool_drop_frames

[G-API] Pipeline modeling tool - support frame dropping for source

* Implement drop frames functionality for dummy src

* Reconsider frame dropping

* Fix comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmatveev dmatveev dmatveev approved these changes

@rgarnov rgarnov rgarnov approved these changes

@mpashchenkov mpashchenkov mpashchenkov approved these changes

+1 more reviewer

@gh0st-offsec gh0st-offsec gh0st-offsec approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dmatveev dmatveev

Labels

category: g-api / gapi

Projects

None yet

Milestone

4.6.0

Development

Successfully merging this pull request may close these issues.

6 participants

@TolyaTalamanov @dmatveev @rgarnov @mpashchenkov @gh0st-offsec @alalek