Use YuNet of fixed input shape to fix not-supported-dynamic-zero-shape for FaceDetectorYN#21607
Merged
alalek merged 2 commits intoopencv:4.xfrom Feb 21, 2022
Merged
Conversation
14 tasks
alalek
reviewed
Feb 18, 2022
| // FIXIT repair assertion | ||
| // Disabled to pass face detector tests from #20422 | ||
| // CV_Assert(!isDynamicShape); // not supported | ||
| CV_Assert(!isDynamicShape); // not supported |
Member
There was a problem hiding this comment.
Updated detection model passes this assertion.
But recognition model doesn't.
Member
Author
There was a problem hiding this comment.
Problem fixed. It was using before-update version of YuNet in the regression test of face recognition.
Contributor
|
@alalek Do you have a plans to merge changes from 4.x branch into 5.x branch soon? |
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
…ynamic_shape Use YuNet of fixed input shape to fix not-supported-dynamic-zero-shape for FaceDetectorYN * use yunet with input of fixed shape * update yunet used in face recognition regression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related bug report: #21340 (comment)
PR for opencv_extra: opencv/opencv_extra#958
If we are using YuNet of fixed input shape as the solution, the one in OpenCV Zoo will need to be updated as well.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.