Merged
Conversation
This is similar to opencv#21527 A macro is also created to simplify the code.
alalek
reviewed
Feb 10, 2022
modules/core/src/hal_internal.cpp
Outdated
Comment on lines
+72
to
+78
| #define CV_ANNOTATE_MEMORY_IS_INITIALIZED(address, size) \ | ||
| do { } while(0) | ||
| #endif | ||
| #else | ||
| #define CV_ANNOTATE_MEMORY_IS_INITIALIZED(address, size) \ | ||
| do { } while(0) | ||
| #endif |
Member
There was a problem hiding this comment.
We could have one fallback declaration:
// no-op fallback
#ifndef CV_ANNOTATE_MEMORY_IS_INITIALIZED
#define CV_ANNOTATE_MEMORY_IS_INITIALIZED(address, size) do { } while(0)
#endif
Contributor
Author
|
BTW, the name of the macro is inspired by the absl one: https://github.com/abseil/abseil-cpp/blob/e3fdd9b16a2a90c9e01e00de46605ce59bebc661/absl/base/dynamic_annotations.h#L242 |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is similar to #21527
A macro is also created to simplify the code.