Merged
Conversation
Because Fortran is called in Lapack, MSAN does not think the memory has been written even though it is the case. MSAN does no support well cross-language memory analysis.
alalek
reviewed
Jan 27, 2022
modules/core/src/hal_internal.cpp
Outdated
| else if(typeid(fptype) == typeid(double)) | ||
| OCV_LAPACK_FUNC(dgesdd)(mode, &m, &n, (double*)a, &lda, (double*)w, (double*)u, &ldu, (double*)vt, &ldv, (double*)buffer, &lwork, iworkBuf, info); | ||
|
|
||
| #if defined(__clang__) && defined(__has_feature) && __has_feature(memory_sanitizer) |
Member
There was a problem hiding this comment.
defined(__has_feature)
should be a dedicated check
#if defined(__clang__) && defined(__has_feature)
#if __has_feature(memory_sanitizer)
#endif
#endif
Contributor
Author
|
BTW, we could probably create a macro at some point like in absl https://github.com/abseil/abseil-cpp/blob/e3fdd9b16a2a90c9e01e00de46605ce59bebc661/absl/base/dynamic_annotations.h#L242 |
alalek
approved these changes
Jan 28, 2022
Merged
vrabaud
added a commit
to vrabaud/opencv
that referenced
this pull request
Feb 10, 2022
This is similar to opencv#21527 A macro is also created to simplify the code.
rogday
pushed a commit
to rogday/opencv
that referenced
this pull request
Feb 17, 2022
* Fix wrong MSAN errors. Because Fortran is called in Lapack, MSAN does not think the memory has been written even though it is the case. MSAN does no support well cross-language memory analysis. * Make a dedicated check.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because Fortran is called in Lapack, MSAN does not think the memory
has been written even though it is the case.
MSAN does no support well cross-language memory analysis.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request