Default FFMPEG VideoCapture backend to rtsp_flags=prefer_tcp#21561
Merged
alalek merged 2 commits intoopencv:4.xfrom Feb 10, 2022
Merged
Default FFMPEG VideoCapture backend to rtsp_flags=prefer_tcp#21561alalek merged 2 commits intoopencv:4.xfrom
alalek merged 2 commits intoopencv:4.xfrom
Conversation
alalek
reviewed
Feb 3, 2022
| char* options = getenv("OPENCV_FFMPEG_CAPTURE_OPTIONS"); | ||
| if(options == NULL) | ||
| { | ||
| #if LIBAVFORMAT_BUILD >= CALC_FFMPEG_VERSION(55, 48, 100) |
Member
There was a problem hiding this comment.
100
It is FFmpeg-specific version component. Original libav has different versions and we don't want to enable this code for libav (e.g. (55, 49, 0) version).
Please add LIBAVUTIL_VERSION_MICRO >= 100 check to ensure that it is FFmpeg fork (see below).
Contributor
Author
There was a problem hiding this comment.
It is FFmpeg-specific version component. Original libav has different versions and we don't want to enable this code for libav (e.g.
(55, 49, 0)version).
I did not know that, thanks, changed to ensure we are cheking the ffmpeg version of libavutil.
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
…ault Default FFMPEG VideoCapture backend to rtsp_flags=prefer_tcp * Make the VideoCapture ffmpeg backends default rtsp connection type prefer_tcp. * Ensure that the ffmpeg version of avformat is checked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply changes discussed in #21558
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.