Skip to content

GAPI FLUID: Enable dynamic dispatching for Split4#21520

Merged
alalek merged 2 commits intoopencv:4.xfrom
alexgiving:atrutnev/simd_for_split4
Jan 31, 2022
Merged

GAPI FLUID: Enable dynamic dispatching for Split4#21520
alalek merged 2 commits intoopencv:4.xfrom
alexgiving:atrutnev/simd_for_split4

Conversation

@alexgiving
Copy link
Copy Markdown
Member

@alexgiving alexgiving commented Jan 26, 2022 •
edited
Loading

Split4 SIMD .xlsx

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Linux AVX2,Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
Xbuild_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

build_image:Custom=centos:7
buildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

Xbuild_image:Custom=ubuntu-openvino-2021.3.0:20.04
build_image:Custom Win=openvino-2021.4.1
build_image:Custom Mac=openvino-2021.2.0

buildworker:Custom Win=windows-3

test_modules:Custom=gapi,python2,python3,java
test_modules:Custom Win=gapi,python2,python3,java
test_modules:Custom Mac=gapi,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
Xtest_opencl:Custom=OFF
Xtest_bigdata:Custom=1
Xtest_filter:Custom=*

CPU_BASELINE:Custom Win=AVX512_SKX
CPU_BASELINE:Custom=SSE4_2

@alexgiving alexgiving force-pushed the atrutnev/simd_for_split4 branch from 1037868 to 2e42dd0 Compare January 31, 2022 12:20
anna-khakimova
anna-khakimova approved these changes Jan 31, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@anna-khakimova anna-khakimova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dmatveev dmatveev added this to the 4.6.0 milestone Jan 31, 2022
dmatveev
dmatveev approved these changes Jan 31, 2022
View reviewed changes
modules/gapi/src/backends/fluid/gfluidcore.cpp
Comment on lines -2540 to -2544
const auto *in = src.InLine<uchar>(0);
auto *out1 = dst1.OutLine<uchar>();
auto *out2 = dst2.OutLine<uchar>();
auto *out3 = dst3.OutLine<uchar>();
auto *out4 = dst4.OutLine<uchar>();
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev Jan 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why do you change this, but the previous formatting has been more column-structured.

Copy link
Copy Markdown
Member Author

@alexgiving alexgiving Jan 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That alignment will be fixed in nearest PRs

@alexgiving alexgiving force-pushed the atrutnev/simd_for_split4 branch from 7d4702b to 667fc9b Compare January 31, 2022 15:45
anna-khakimova
anna-khakimova approved these changes Jan 31, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@anna-khakimova anna-khakimova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alalek alalek merged commit 245f627 into opencv:4.x Jan 31, 2022
@alexgiving alexgiving mentioned this pull request Feb 1, 2022
Merged
6 tasks
@alalek alalek mentioned this pull request Feb 22, 2022
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
Merge pull request opencv#21520 from alexgiving:atrutnev/simd_for_split4
09df7b6 
GAPI FLUID: Enable dynamic dispatching for Split4

* Enable dynamic dispatching for split4

* Add tail proc for split3 and split4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmatveev dmatveev dmatveev approved these changes

@anna-khakimova anna-khakimova anna-khakimova approved these changes

Assignees

@dmatveev dmatveev

Labels

category: g-api / gapi optimization

Projects

None yet

Milestone

4.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@alexgiving @dmatveev @anna-khakimova @alalek