G-API media format gray by dbudniko · Pull Request #21511 · opencv/opencv

dbudniko · 2022-01-25T10:25:48Z

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
The PR is proposed to the proper branch
There is a reference to the original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

Xbuild_image:Custom=centos:7
Xbuildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

build_image:Custom=ubuntu-openvino-2021.4.1:20.04
build_image:Custom Win=openvino-2021.4.1
build_image:Custom Mac=openvino-2021.4.1

test_modules:Custom=gapi,python2,python3,java
test_modules:Custom Win=gapi,python2,python3,java
test_modules:Custom Mac=gapi,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

…rmat_gray

modules/gapi/src/backends/ie/giebackend.cpp

modules/gapi/src/backends/streaming/gstreamingbackend.cpp

smirnov-alexey · 2022-01-26T09:53:20Z

@dbudniko please, add tests on GRAY color format

AsyaPronina

Should we also extend gapi_frame_tests.cpp and, if inference works, gapi_infer_ie_test.cpp also?

modules/gapi/src/backends/ie/giebackend.cpp

modules/gapi/src/backends/streaming/gstreamingbackend.cpp

AsyaPronina · 2022-01-27T10:43:32Z

modules/gapi/src/backends/streaming/gstreamingbackend.cpp

+        {
+            std::call_once(m_warnFlag,
+                []() {
+                    GAPI_LOG_WARNING(NULL, "\nOn-the-fly conversion from GRAY to NV12 Y plane will "


This warning is not applicable here, if to be honest..
This accessor tries to return Y cv::Mat from any given frame. For GRAY frames it is enough to just return their data as Y planes. There is no expected time-consuming conversions.
Warning was about situation when we trying to access, for example, Y plane from BGR cv::MediaFrame. So, the conversion needs to be happen inside from BGR to NV12 and, then, Y plane can only be retrieved. As BGR input frame might have high enough resolution, conversion might be time-consuming and that is why warning is created.
So, here it might be omitted

I'd keep a message here that requested plane here doesn't not quite align with the initial format

modules/gapi/src/backends/streaming/gstreamingbackend.cpp

…/opencv into dbudniko/gapi_media_format_gray

dbudniko · 2022-01-28T10:14:54Z

3 new streaming tests with gray are OK now.

dbudniko · 2022-01-28T12:08:49Z

Media Frame added and green now. Please review. We still have open regarding correct color conversion approach in streaming tests. Discussed it with Asya. Need your inputs to left one. #if0 #else #endif temporary left in the tests source code.

modules/gapi/test/gapi_frame_tests.cpp

modules/gapi/src/backends/streaming/gstreamingbackend.cpp

modules/gapi/test/gapi_frame_tests.cpp

modules/gapi/test/streaming/gapi_streaming_tests.cpp

dmatveev

Looks good overall

modules/gapi/src/backends/ie/giebackend.cpp

modules/gapi/src/backends/streaming/gstreamingbackend.cpp

modules/gapi/test/streaming/gapi_streaming_tests.cpp

dbudniko · 2022-02-01T15:15:47Z

@alalek please merge.

AsyaPronina

I suggest to discuss IE backend GRAY support last time
Please sorry for incoveniences!

modules/gapi/src/backends/ie/giebackend.cpp

modules/gapi/src/backends/streaming/gstreamingbackend.cpp

dbudniko · 2022-02-03T09:24:44Z

@alalek gentle reminder

…mat_gray G-API media format gray

Dmitry Budnikov added 2 commits January 25, 2022 12:29

gray draft

e0cb364

Merge remote-tracking branch 'origin/4.x' into dbudniko/gapi_media_fo…

a7e0ea8

…rmat_gray

sivanov-work reviewed Jan 25, 2022

View reviewed changes

modules/gapi/src/backends/ie/giebackend.cpp Outdated Show resolved Hide resolved

modules/gapi/src/backends/streaming/gstreamingbackend.cpp Outdated Show resolved Hide resolved

modules/gapi/src/backends/streaming/gstreamingbackend.cpp Outdated Show resolved Hide resolved

remove uv_plane from gray code path

a5956e6

AsyaPronina reviewed Jan 27, 2022

View reviewed changes

Dmitry Budnikov added 15 commits January 27, 2022 16:23

trying to address comments from Asya (accessors are modified)

198e6e1

try to push one more time

52adfdc

address more comments from Asya and Sergey

987ce91

add gray to streaming tests

bd796c8

some gray source corrections and copy gray frame

6795ecf

try to fix copy frame gray test

10bc6fd

try to add reshape gray test

338473e

fix test source

76a6735

disable reshape gray test

3fc50fa

debug prints

1886642

Merge branch 'dbudniko/gapi_media_format_gray' of github.com:dbudniko…

7a308cb

…/opencv into dbudniko/gapi_media_format_gray

try to convert BGR to gray

e7e98ec

roll back

10d6b76

try to fix gray reshape test

8e83d55

clean up

add328f

Dmitry Budnikov added 2 commits January 28, 2022 14:21

try bgr to gray again

7983d37

try to add media frame tests

7f3fdb7

size media frame gray test

da64f69

smirnov-alexey reviewed Jan 28, 2022

View reviewed changes

modules/gapi/test/gapi_frame_tests.cpp Show resolved Hide resolved

AsyaPronina reviewed Jan 29, 2022

View reviewed changes

Dmitry Budnikov added 2 commits January 31, 2022 14:30

more comments are addressed

8446626

rmat on mat adapter

f74f205

Dmitry Budnikov added 4 commits January 31, 2022 16:07

more streaming tests

1fae2d0

try to add more test instances

f8a0dca

try to fix accuracy

155a2cd

remove source type gray

1884dd0

dmatveev self-assigned this Jan 31, 2022

dmatveev added the category: g-api / gapi label Jan 31, 2022

dmatveev added this to the 4.6.0 milestone Jan 31, 2022

Dmitry Budnikov added 4 commits January 31, 2022 17:24

streaming tests fix - source type gray

d89a8d4

fix streaming test logic

a272fe1

try to fix test

e025398

clean up

22282c9

dmatveev approved these changes Jan 31, 2022

View reviewed changes

modules/gapi/src/backends/ie/giebackend.cpp Show resolved Hide resolved

modules/gapi/src/backends/streaming/gstreamingbackend.cpp Outdated Show resolved Hide resolved

modules/gapi/src/backends/streaming/gstreamingbackend.cpp Outdated Show resolved Hide resolved

return back single flag

0ce365f

AsyaPronina reviewed Jan 31, 2022

View reviewed changes

modules/gapi/test/streaming/gapi_streaming_tests.cpp Outdated Show resolved Hide resolved

Dmitry Budnikov added 2 commits February 1, 2022 15:43

remove redundant coma

0153a46

fix assert to fix debug tests run

273d007

dbudniko unassigned dmatveev Feb 1, 2022

AsyaPronina reviewed Feb 1, 2022

View reviewed changes

modules/gapi/src/backends/ie/giebackend.cpp Show resolved Hide resolved

modules/gapi/src/backends/streaming/gstreamingbackend.cpp Show resolved Hide resolved

AsyaPronina approved these changes Feb 2, 2022

View reviewed changes

alalek assigned dmatveev Feb 3, 2022

alalek merged commit 4d0148b into opencv:4.x Feb 3, 2022

TolyaTalamanov pushed a commit to TolyaTalamanov/opencv that referenced this pull request Feb 18, 2022

Merge pull request opencv#21511 from dbudniko:dbudniko/gapi_media_for…

ae96a28

…mat_gray G-API media format gray

alalek mentioned this pull request Feb 22, 2022

(5.x) Merge 4.x #21651

Merged

a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023

Merge pull request opencv#21511 from dbudniko:dbudniko/gapi_media_for…

e738523

…mat_gray G-API media format gray

Uh oh!

Conversation

dbudniko commented Jan 25, 2022

Pull Request Readiness Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

smirnov-alexey commented Jan 26, 2022

Uh oh!

AsyaPronina left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

AsyaPronina Jan 27, 2022

Choose a reason for hiding this comment

Uh oh!

dbudniko Jan 28, 2022

Choose a reason for hiding this comment

Uh oh!

smirnov-alexey Jan 28, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dbudniko commented Jan 28, 2022

Uh oh!

dbudniko commented Jan 28, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dmatveev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dbudniko commented Feb 1, 2022

Uh oh!

AsyaPronina left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dbudniko commented Feb 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants