[G-API] Implement G-API pipeline modeling tool#21477
Merged
alalek merged 10 commits intoopencv:4.xfrom Feb 1, 2022
Merged
Conversation
TolyaTalamanov
commented
Jan 19, 2022
TolyaTalamanov
commented
Jan 19, 2022
| @@ -0,0 +1,893 @@ | |||
| import os | |||
Contributor
Author
There was a problem hiding this comment.
@alalek Is is possible to run these tests as part of precommit job?
Member
There was a problem hiding this comment.
Only functional tests are launched (with filtering capability and proper checks).
We don't test tools or samples. No plans to change that.
Contributor
Author
There was a problem hiding this comment.
Got it, thanks!
Contributor
Author
|
@alalek @mshabunin Could you have a look, please? |
mshabunin
approved these changes
Jan 24, 2022
alalek
reviewed
Jan 24, 2022
modules/gapi/CMakeLists.txt
Outdated
| ocv_target_link_libraries(example_gapi_pipeline_builder_tool winmm.lib) | ||
| endif() | ||
| file(GLOB_RECURSE pipeline_builder_configs "${CMAKE_CURRENT_LIST_DIR}/samples/pipeline_builder/configs/*.yml") | ||
| install(FILES ${pipeline_builder_configs} DESTINATION "${OPENCV_OTHER_INSTALL_PATH}/pipeline_builder_configs") |
Member
There was a problem hiding this comment.
install
COMPONENT samples must be added here.
| #include <opencv2/highgui.hpp> // cv::CommandLineParser | ||
| #include <opencv2/core/utils/filesystem.hpp> | ||
|
|
||
| #if defined(WIN32) |
Member
There was a problem hiding this comment.
_WIN32
https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170
Just WIN32 is not a compiler definition.
alalek
reviewed
Jan 26, 2022
| CloseHandle(timer); | ||
| #else | ||
| using namespace std::chrono; | ||
| std::this_thread::sleep_for(duration<double, std::milli>(ms)); |
Member
There was a problem hiding this comment.
Why this code can't work with WIN32?
Contributor
Author
There was a problem hiding this comment.
It can, but it doesn't work as precisely as we would like
Member
|
Need to make builds green before merge. |
This reverts commit 6748a24.
- use `-DINSTALL_C_EXAMPLES=ON`
alalek
approved these changes
Feb 1, 2022
TolyaTalamanov
added a commit
to TolyaTalamanov/opencv
that referenced
this pull request
Feb 18, 2022
…er-tool [G-API] Implement G-API pipeline modeling tool * Implement G-API pipeline builder tool * Remove whitespaces from config * Remove unused unittest stuff * Fix comments to review * Fix MAC warning * Rename to pipeline_modeling_tool * Move to opencv apps * Move config to gapi/samples/data * gapi: samples sources are installed automatically
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
…er-tool [G-API] Implement G-API pipeline modeling tool * Implement G-API pipeline builder tool * Remove whitespaces from config * Remove unused unittest stuff * Fix comments to review * Fix MAC warning * Rename to pipeline_modeling_tool * Move to opencv apps * Move config to gapi/samples/data * gapi: samples sources are installed automatically
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
Build configuration