Skip to content

Adapt remote inference to operate with NV12 blobs#21424

Merged
alalek merged 2 commits intoopencv:4.xfrom
dbudniko:dbudniko/media_frame_adapter_enabling
Jan 12, 2022
Merged

Adapt remote inference to operate with NV12 blobs#21424
alalek merged 2 commits intoopencv:4.xfrom
dbudniko:dbudniko/media_frame_adapter_enabling

Conversation

@dbudniko
Copy link
Copy Markdown

@dbudniko dbudniko commented Jan 11, 2022

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

Xbuild_image:Custom=centos:7
Xbuildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

build_image:Custom=ubuntu-openvino-2021.4.1:20.04
build_image:Custom Win=openvino-2021.4.1
build_image:Custom Mac=openvino-2021.4.1

test_modules:Custom=gapi,python2,python3,java
test_modules:Custom Win=gapi,python2,python3,java
test_modules:Custom Mac=gapi,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

smirnov-alexey
smirnov-alexey reviewed Jan 11, 2022
View reviewed changes
smirnov-alexey
smirnov-alexey reviewed Jan 11, 2022
View reviewed changes
smirnov-alexey
smirnov-alexey reviewed Jan 11, 2022
View reviewed changes
@smirnov-alexey
Copy link
Copy Markdown
Contributor

smirnov-alexey commented Jan 11, 2022

Overall looks good to me. @sivanov-work could you take a look? I believe it might affect #21232

@smirnov-alexey
Copy link
Copy Markdown
Contributor

smirnov-alexey commented Jan 11, 2022

I'd also change a name of this PR to something more accurate - like Adapt remote inference to operate with NV12 blobs or something like that

@sivanov-work
Copy link
Copy Markdown
Contributor

sivanov-work commented Jan 12, 2022

@smirnov-alexey thanks for noticing. I think I'm being managed to apply this approach in my PR

@dbudniko
Copy link
Copy Markdown
Author

dbudniko commented Jan 12, 2022

Build and tests run is OK with the latest changes. Can we resolve open conversations and proceed to merge?

smirnov-alexey
smirnov-alexey approved these changes Jan 12, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@smirnov-alexey smirnov-alexey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@alalek alalek merged commit 19bbe6c into opencv:4.x Jan 12, 2022
@alalek alalek mentioned this pull request Feb 22, 2022
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
Merge pull request opencv#21424 from dbudniko:dbudniko/media_frame_ad…
9a5664f 
…apter_enabling

Adapt remote inference to operate with NV12 blobs

* Media Frame Adapter support

* address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sivanov-work sivanov-work sivanov-work left review comments

@smirnov-alexey smirnov-alexey smirnov-alexey approved these changes

@AsyaPronina AsyaPronina Awaiting requested review from AsyaPronina

@TolyaTalamanov TolyaTalamanov Awaiting requested review from TolyaTalamanov

Assignees

@smirnov-alexey smirnov-alexey

Labels

category: g-api / gapi feature

Projects

None yet

Milestone

4.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@dbudniko @smirnov-alexey @sivanov-work @alalek