Skip to content

Update stitching_detailed.py#21413

Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom
berak:patch-1
Jan 11, 2022
Merged

Update stitching_detailed.py#21413
opencv-pushbot merged 1 commit intoopencv:4.xfrom
berak:patch-1

Conversation

@berak
Copy link
Copy Markdown
Contributor

@berak berak commented Jan 9, 2022 •
edited
Loading

resolves: #21406

use Matcher constructors consistently

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@berak
Update stitching_detailed.py
5602d2c 
resolves: opencv#21406

use constructors consistently
@asenyaev
Copy link
Copy Markdown
Contributor

asenyaev commented Jan 11, 2022

Hi @berak! Could you also add tests for these methods?

alalek
alalek approved these changes Jan 11, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@opencv-pushbot opencv-pushbot merged commit a5894f3 into opencv:4.x Jan 11, 2022
@berak
Copy link
Copy Markdown
Contributor Author

berak commented Jan 11, 2022

hi @asenyaev , did you mean, apart from existing minimal test code here,
like : validating the created instance by calling some method on it ?

@berak berak deleted the patch-1 branch January 11, 2022 16:56
@alalek alalek mentioned this pull request Feb 22, 2022
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@lukasalexanderweber
Merge pull request opencv#21420 from lukasalexanderweber:4.x
6022a5d 
Introduce Cropping to OpenCV Stitching Tool

* Introduced Cropping

* integrate opencv#21413

* fixed failing subsetter tests

* updated stuff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

bug category: python bindings category: samples category: stitching

Projects

None yet

Milestone

4.6.0

Development

Successfully merging this pull request may close these issues.

Missing BestOf2NearestRangeMatcher_create in bindings

4 participants

@berak @asenyaev @alalek @opencv-pushbot