Allow cv::cuda::Event to accept combinations of flags#21374
Merged
alalek merged 15 commits intoopencv:4.xfrom Jan 11, 2022
Merged
Allow cv::cuda::Event to accept combinations of flags#21374alalek merged 15 commits intoopencv:4.xfrom
alalek merged 15 commits intoopencv:4.xfrom
Conversation
Old flag resulted in software implementation being selected when the Intel decoder is not the primary adapter.
6 tasks
alalek
reviewed
Jan 11, 2022
| }; | ||
|
|
||
| CV_WRAP explicit Event(Event::CreateFlags flags = Event::CreateFlags::DEFAULT); | ||
| CV_WRAP explicit Event(const unsigned flags = Event::CreateFlags::DEFAULT); |
Member
There was a problem hiding this comment.
Could you try to reuse CV_ENUM_FLAGS(...) approach instead?
alalek
approved these changes
Jan 11, 2022
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
Allow cv::cuda::Event to accept combinations of flags
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow
cv::cuda::Eventto accept combinations of flags as implied by the Nvidia docs:cudaEventDisableTiming: Specifies that the created event does not need to record timing data. Events created with this flag specified and the cudaEventBlockingSync flag not specified will provide the best performance when used with cudaStreamWaitEvent() and cudaEventQuery().
cudaEventInterprocess: Specifies that the created event may be used as an interprocess event by cudaIpcGetEventHandle(). cudaEventInterprocess must be specified along with cudaEventDisableTiming.
Currently there are no event tests, these have been added to opencv/opencv_contrib#3144.
Additionaly there are currently two Event and Stream classes inside the repo, one inside cv::cuda and one inside cv::dnn::cuda4dnn::csl. Is there any requirement to merge them or have them inherit from the same base class?
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.