G-API: Suppress ngraph warnings for MSVS2015 (4268)#21362
Merged
alalek merged 3 commits intoopencv:4.xfrom Jan 19, 2022
Merged
Conversation
alalek
reviewed
Dec 29, 2021
| #pragma warning(push) | ||
| #pragma warning(disable : 4100) | ||
| # if _MSC_VER < 1900 | ||
| # pragma warning(disable:4268) // Disable warnings of ngraph. OpenVINO recommends use MSVS 2019. |
Member
There was a problem hiding this comment.
1900 is MSVS 2015
This condition doesn't work at all.
Contributor
Author
There was a problem hiding this comment.
"1900 is MSVS 2015" - I know. Local build was successful with this condition. But OV package was fresher.
Sorry for experiment.
Member
|
@mpashchenkov What is the status of this PR? Is it ready to be merged? |
Contributor
Author
|
@alalek, I think yes. PR contains simple disabling for two msvs2015 warnings. Origin - ngraph's header. Does PR need one more review from someone? |
alalek
approved these changes
Jan 19, 2022
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
…s-warn G-API: Suppress ngraph warnings for MSVS2015 (4268) * 4268 are suppressed * 1900-->>1910 (v140) * Two more warnings from ngraph include
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates #21134
OpenVINO recommends to use MSVS 2019. Warnings (4268) are disabled.