Skip to content

G-API: Fix Win32 build: uint64_t ->size_t#21230

Merged
alalek merged 2 commits intoopencv:4.xfrom
sivanov-work:gapi_win32_vpl_fix
Dec 10, 2021
Merged

G-API: Fix Win32 build: uint64_t ->size_t#21230
alalek merged 2 commits intoopencv:4.xfrom
sivanov-work:gapi_win32_vpl_fix

Conversation

@sivanov-work
Copy link
Copy Markdown
Contributor

@sivanov-work sivanov-work commented Dec 10, 2021 •
edited
Loading

Fix for issue
#21225

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Linux x64,Docs,Linux32,Win32, Mac

alalek
alalek reviewed Dec 10, 2021
View reviewed changes
modules/gapi/samples/onevpl_infer_single_roi.cpp Outdated
const auto streaming_queue_capacity = cmd.get<uint64_t>("streaming_queue_capacity");
const auto source_queue_capacity = cmd.get<uint64_t>("frames_pool_size");
const auto streaming_queue_capacity = cmd.get<size_t>("streaming_queue_capacity");
const auto source_queue_capacity = cmd.get<size_t>("frames_pool_size");
Copy link
Copy Markdown
Member

@alalek alalek Dec 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.get<size_t>()

Not all types are supported in CommandLineParser.
Here we can use .get<int> + check>=0 + cast

Copy link
Copy Markdown
Contributor Author

@sivanov-work sivanov-work Dec 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks
i've faced with this too... added one more commit with implicit type expanding (uint32-> ...) for x86_64 system

@sivanov-work
Copy link
Copy Markdown
Contributor Author

sivanov-work commented Dec 10, 2021

@alalek Looks like all required build have been passed: i hope it ready for merge

@dmatveev dmatveev self-assigned this Dec 10, 2021
@alalek alalek merged commit b70370f into opencv:4.x Dec 10, 2021
@sivanov-work sivanov-work deleted the gapi_win32_vpl_fix branch December 10, 2021 09:22
@alalek alalek mentioned this pull request Dec 30, 2021
Merged
@alalek alalek mentioned this pull request Feb 22, 2022
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@sivanov-work
Merge pull request opencv#21230 from sivanov-work:gapi_win32_vpl_fix
fb6ad70 
G-API: Fix Win32 build: uint64_t ->size_t

* Fix Win32 build: uint64_t ->size_t

* Fix for MAC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek left review comments

@dmatveev dmatveev dmatveev approved these changes

Assignees

@dmatveev dmatveev

Labels

bug category: build/install category: g-api / gapi

Projects

None yet

Milestone

4.5.5

Development

Successfully merging this pull request may close these issues.

G-API: broken Win32 builds

3 participants

@sivanov-work @dmatveev @alalek