fix unicode errors for framework headers#21227
Merged
alalek merged 2 commits intoopencv:4.xfrom Dec 10, 2021
Merged
Conversation
This would crash if the header file included non-ASCII characters. This change ensures that headers are read and written as UTF-8 encoded files instead of ascii.
alalek
reviewed
Dec 9, 2021
platforms/ios/build_framework.py
Outdated
| for filename in files: | ||
| filepath = os.path.join(dirname, filename) | ||
| with open(filepath) as file: | ||
| with codecs.open(filepath,"r","utf-8") as file: |
Member
There was a problem hiding this comment.
In gen_objc.py we using:
with io.open(filepath, encoding="utf-8", errors="ignore") as file:
Please use space after comma.
Contributor
Author
There was a problem hiding this comment.
codecs.open() is used elsewhere in this file, so I chose it for consistency. Spaces have been added.
alalek
approved these changes
Dec 10, 2021
Merged
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
…eaders * fix unicode errors for framework headers This would crash if the header file included non-ASCII characters. This change ensures that headers are read and written as UTF-8 encoded files instead of ascii. * Adds spaces after commas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating a macos framework using the
build_framework.pyscript, if a different name has been chosen for the framework (using the--framework_nameoption), the headers must all be updated to use this new name as well. However, this script will throw an exception if the header file included non-ASCII characters, since the files are opened and saved in ASCII mode. This change ensures that headers are read and written as UTF-8 encoded files instead of ascii.Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.