Skip to content

GitHub Action to lint Python code#21121

Merged
alalek merged 3 commits intoopencv:4.xfrom
cclauss:patch-2
Nov 26, 2021
Merged

GitHub Action to lint Python code#21121
alalek merged 3 commits intoopencv:4.xfrom
cclauss:patch-2

Conversation

@cclauss
Copy link
Copy Markdown
Contributor

@cclauss cclauss commented Nov 25, 2021 •
edited
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Test results: https://github.com/cclauss/opencv/actions
Related to #21122

cclauss added a commit to cclauss/opencv that referenced this pull request Nov 25, 2021
@cclauss
Use ==/!= to compare constant literals (str, bytes, int, float, tuple)
f95e71d 
Avoid `SyntaxWarning` on Python >= 3.8
```
>>> "convolutional" == "convolutional"
True
>>> "convolutional" is "convolutional"
<stdin>:1: SyntaxWarning: "is" with a literal. Did you mean "=="?
True
```
Related to opencv#21121
@cclauss cclauss mentioned this pull request Nov 25, 2021
Merged
6 tasks
cclauss added a commit to cclauss/opencv that referenced this pull request Nov 25, 2021
@cclauss
Use ==/!= to compare constant literals (str, bytes, int, float, tuple)
9cc60c9 
Avoid `SyntaxWarning` on Python >= 3.8
```
>>> "convolutional" == "convolutional"
True
>>> "convolutional" is "convolutional"
<stdin>:1: SyntaxWarning: "is" with a literal. Did you mean "=="?
True
```
Related to opencv#21121
alalek
alalek reviewed Nov 26, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution!

@cclauss @alalek
Move from automatic events to manual ones
dc83f1b 
Co-authored-by: Alexander Alekhin <alexander.a.alekhin@gmail.com>
This was referenced Nov 26, 2021
Merged
Merged
Merged
@cclauss
Copy link
Copy Markdown
Contributor Author

cclauss commented Nov 26, 2021

Given the change to on: workflow_dispatch, how will this ever get run?

@cclauss cclauss requested a review from alalek November 26, 2021 11:40
@alalek alalek merged commit d668aa7 into opencv:4.x Nov 26, 2021
@alalek
Copy link
Copy Markdown
Member

alalek commented Nov 26, 2021

https://github.blog/changelog/2020-07-06-github-actions-manual-triggers-with-workflow_dispatch/

@cclauss cclauss deleted the patch-2 branch November 26, 2021 18:28
@cclauss
Copy link
Copy Markdown
Contributor Author

cclauss commented Nov 26, 2021 •
edited
Loading

You will then see a ‘Run workflow’ button on the Actions tab, enabling you to easily trigger a run.

But this repo does not have an Actions tab.

Screenshot 2021-11-26 at 19 38 08

@alalek alalek mentioned this pull request Dec 30, 2021
Merged
@alalek alalek mentioned this pull request Feb 22, 2022
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@cclauss
Merge pull request opencv#21121 from cclauss:patch-2
3cff488 
* GitHub Action to lint Python code

* Move from automatic events to manual ones

* flake8: Do not look for undefined names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cclauss @alalek