Skip to content

Update cap_android_camera.cpp#21108

Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom
ShuangLiu1992:patch-1
Nov 24, 2021
Merged

Update cap_android_camera.cpp#21108
opencv-pushbot merged 1 commit intoopencv:4.xfrom
ShuangLiu1992:patch-1

Conversation

@ShuangLiu1992
Copy link
Copy Markdown
Contributor

@ShuangLiu1992 ShuangLiu1992 commented Nov 23, 2021

since u and v Pixel ptr have been swapped the compare condition should be updated too

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
android_pack_config=ndk-18-api-level-21.config.py

since u and v Pixel ptr have been swapped the compare condition should be updated too
@ShuangLiu1992
Copy link
Copy Markdown
Contributor Author

ShuangLiu1992 commented Nov 23, 2021

@alalek
Copy link
Copy Markdown
Member

alalek commented Nov 23, 2021

relates #20529
/cc @saikatnanda @komakai

@komakai
Copy link
Copy Markdown
Contributor

komakai commented Nov 24, 2021

@alalek @ShuangLiu1992
I tested the fix - looks good

Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShuangLiu1992 Thank you for the patch 👍

@komakai Thank you for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants