Fix YUV indexes + YUV Planner detection condition#20529
Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom Aug 12, 2021
Merged
Fix YUV indexes + YUV Planner detection condition#20529opencv-pushbot merged 1 commit intoopencv:masterfrom
opencv-pushbot merged 1 commit intoopencv:masterfrom
Conversation
Author
|
@komakai I have created this fresh PR to address the crash issue. The changes are rolled up into one commit after rebasing with latest master. Hopefully this helps to address the build failure. |
Author
|
@komakai are we in good shape for this PR to move on? |
Contributor
@saikatnanda from my point of view looks good. But you'll need one of the maintainers to review/merge (@alalek ?) |
alalek
approved these changes
Aug 12, 2021
Member
alalek
left a comment
There was a problem hiding this comment.
@saikatnanda Thank you for contribution 👍
@komakai Thank you for the review!
Author
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continues #20509
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
The code was crashing on buffer.insert() line#330 on Android 11 Emulator with Camera2 NDK. This is tested with a C++ Test Application.
It looks like the U & V indexes are reversed and the YUVPlaner check condition is having an assignment operator than
==.This fix satisfies the YUV buffer memory layout expectation as in https://en.wikipedia.org/wiki/YUV#/media/File:Yuv420.svg