Skip to content

G-API: Cleaning samples#21106

Merged
alalek merged 5 commits intoopencv:4.xfrom
mpashchenkov:mp/ocv-gapi-clean-samples
Nov 26, 2021
Merged

G-API: Cleaning samples#21106
alalek merged 5 commits intoopencv:4.xfrom
mpashchenkov:mp/ocv-gapi-clean-samples

Conversation

@mpashchenkov
Copy link
Copy Markdown
Contributor

@mpashchenkov mpashchenkov commented Nov 23, 2021 •
edited
Loading

Cleaning G-API samples.
Removed ParseSSD custom kernels. cv::gapi::parseSSD instead.
Added graph operations for semantic segmentation instead operations in a kernel.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Build Configuration

force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

Xbuild_image:Custom=centos:7
Xbuildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

build_image:Custom=ubuntu-openvino-2021.4.1:20.04
build_image:Custom Win=openvino-2021.4.1
build_image:Custom Mac=openvino-2021.4.1

test_modules:Custom=gapi,python2,python3,java
test_modules:Custom Win=gapi,python2,python3,java
test_modules:Custom Mac=gapi,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

@mpashchenkov mpashchenkov force-pushed the mp/ocv-gapi-clean-samples branch from 3a17b73 to 6459fe5 Compare November 24, 2021 07:03
@mpashchenkov mpashchenkov marked this pull request as ready for review November 24, 2021 07:11
@alexgiving
Copy link
Copy Markdown
Member

alexgiving commented Nov 24, 2021

Overall, LGTM

@mpashchenkov mpashchenkov force-pushed the mp/ocv-gapi-clean-samples branch from af7f868 to a79b955 Compare November 24, 2021 09:30
alexgiving
alexgiving reviewed Nov 24, 2021
View reviewed changes
alexgiving
alexgiving approved these changes Nov 24, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@alexgiving alexgiving left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dmatveev
Copy link
Copy Markdown
Contributor

dmatveev commented Nov 25, 2021

Added graph operations for semantic segmentation instead operations in a kernel.

Did the performance change somehow after that?

@dmatveev dmatveev self-assigned this Nov 25, 2021
@dmatveev dmatveev added this to the 4.5.5 milestone Nov 25, 2021
dmatveev
dmatveev reviewed Nov 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please make sure all our sample still work :)

dmatveev
dmatveev approved these changes Nov 26, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alalek
Copy link
Copy Markdown
Member

alalek commented Nov 26, 2021

@mpashchenkov Please fix left warnings from Windows builders.

@alalek alalek merged commit b95d71a into opencv:4.x Nov 26, 2021
@alalek alalek mentioned this pull request Dec 30, 2021
Merged
@mpashchenkov mpashchenkov mentioned this pull request Feb 2, 2022
Closed
6 tasks
@alalek alalek mentioned this pull request Feb 22, 2022
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
Merge pull request opencv#21106 from mpashchenkov:mp/ocv-gapi-clean-s…
a89848f 
…amples

G-API: Cleaning samples

* parseSSD + removed render details from gcpukernel

* self-rev

* Applying comment

* Added operators

* warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmatveev dmatveev dmatveev approved these changes

@alexgiving alexgiving alexgiving approved these changes

Assignees

@dmatveev dmatveev

Labels

category: g-api / gapi category: samples

Projects

None yet

Milestone

4.5.5

Development

Successfully merging this pull request may close these issues.

4 participants

@mpashchenkov @alexgiving @dmatveev @alalek