[G-API] Fix issue of getting 1D Mat out of RMat::View#21103
Merged
alalek merged 3 commits intoopencv:4.xfrom Nov 26, 2021
Merged
[G-API] Fix issue of getting 1D Mat out of RMat::View#21103alalek merged 3 commits intoopencv:4.xfrom
alalek merged 3 commits intoopencv:4.xfrom
Conversation
- added test - fixed for standalone too (removed Assert(dims.empty()))
alalek
reviewed
Nov 23, 2021
| } | ||
| return m; | ||
| } | ||
| #else |
Member
There was a problem hiding this comment.
Perhaps #else part should be fixed too.
Contributor
Author
There was a problem hiding this comment.
Yes, there are changes for standalone to support 1D, but not here they are required (as local testing shows)
Added standalone changes in asView()
Merged
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
…ew_issue [G-API] Fix issue of getting 1D Mat out of RMat::View * Fix issue of getting 1D Mat out of RMat::View - added test - fixed for standalone too (removed Assert(dims.empty())) * Fixed asVeiw() function for standalone * Put more detailed comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mat.dimsto2incv::Matconstructors even if source Mat'sdims == 1asView()logic)Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.