Skip to content

Update drawing.cpp#20987

Merged
alalek merged 3 commits intoopencv:4.xfrom
zcx-xxx:master
Nov 19, 2021
Merged

Update drawing.cpp#20987
alalek merged 3 commits intoopencv:4.xfrom
zcx-xxx:master

Conversation

@zcx-xxx
Copy link
Copy Markdown
Contributor

@zcx-xxx zcx-xxx commented Nov 1, 2021 •
edited
Loading

optimize FillEdgeCollection function

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@zcx-xxx
Update drawing.cpp
8628c09 
optimize FillEdgeCollection function
alalek
alalek reviewed Nov 2, 2021
View reviewed changes
modules/imgproc/src/drawing.cpp
te->next = last;
prelast = te;
sort_flag = 1;
last_exchange = prelast;
Copy link
Copy Markdown
Member

@alalek alalek Nov 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we don't need sort_flag anymore.

sort_flag == 1 iff last_exchange != NULL

if (last_exchange == NULL)
    break;

before "while"

Copy link
Copy Markdown
Contributor Author

@zcx-xxx zcx-xxx Nov 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's right

Copy link
Copy Markdown
Member

@alalek alalek Nov 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zcx-xxx Could you please to update PR?

Copy link
Copy Markdown
Contributor Author

@zcx-xxx zcx-xxx Nov 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I haven't read it recently. The PR has been updated

@zcx-xxx
Update drawing.cpp
09c2423 
optimize FillEdgeCollection，remove sort_flag
@zcx-xxx
Merge pull request #1 from opencv/master
09a7448 
Master
alalek
alalek approved these changes Nov 19, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@alalek alalek merged commit f5de714 into opencv:4.x Nov 19, 2021
@alalek alalek mentioned this pull request Dec 30, 2021
Merged
@sturkmen72 sturkmen72 mentioned this pull request Feb 14, 2022
Closed
@alalek alalek mentioned this pull request Feb 22, 2022
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@zcx-xxx
Merge pull request opencv#20987 from zcx-xxx:master
2da0db0 
* Update drawing.cpp

optimize FillEdgeCollection function

* Update drawing.cpp

optimize FillEdgeCollection，remove sort_flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: imgproc optimization

Projects

None yet

Milestone

4.5.5

Development

Successfully merging this pull request may close these issues.

2 participants

@zcx-xxx @alalek