Merged
Conversation
alalek
reviewed
Oct 26, 2021
modules/videoio/test/test_audio.cpp
Outdated
|
|
||
| class CheckIsOpen : public IsOpenTestFixture{}; | ||
|
|
||
| TEST_P(CheckIsOpen, audio) |
Member
There was a problem hiding this comment.
TEST_P(CheckIsOpen, audio)
TEST_P(AudioOpenCheck, bad_arg)
modules/videoio/test/test_audio.cpp
Outdated
| TEST_P(CheckIsOpen, audio) | ||
| { | ||
| if (!videoio_registry::hasBackend(cv::VideoCaptureAPIs(backend))) | ||
| throw SkipTestException(cv::videoio_registry::getBackendName(backend) + " backend was not found"); |
Member
There was a problem hiding this comment.
open() should fail anyway, so backend check is not necessary.
modules/videoio/test/test_audio.cpp
Outdated
| if (!videoio_registry::hasBackend(cv::VideoCaptureAPIs(backend))) | ||
| throw SkipTestException(cv::videoio_registry::getBackendName(backend) + " backend was not found"); | ||
|
|
||
| doTest(); |
Member
There was a problem hiding this comment.
We really don't need to parametrize these tests on such detailed level (or parametrize backend only).
Test code is small with one check and parameters just increase complexity.
Also test names would become more descriptive: bad_arg_invalid_audio_stream
alalek
approved these changes
Oct 26, 2021
Merged
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
Audio patch * fixed microphone, audio position * fixed docs * changed AudioOpenCheck
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@alalek